Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 98543004: Remove usage of deprecated V8 APIs from c/r/extensions (Closed)

Created:
7 years ago by jochen (gone - plz use gerrit)
Modified:
7 years ago
Reviewers:
Jói, marja
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Remove usage of deprecated V8 APIs from c/r/extensions BUG=324225 R=joi@chromium.org, marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238095

Patch Set 1 #

Total comments: 5

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -149 lines) Patch
M PRESUBMIT.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/api_activity_logger.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/app_bindings.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/binding_generating_native_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_context.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_context_set.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/console.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/document_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/dom_activity_logger.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/renderer/extensions/event_bindings.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M chrome/renderer/extensions/i18n_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/logging_native_handler.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/messaging_bindings.cc View 5 chunks +13 lines, -12 lines 0 comments Download
M chrome/renderer/extensions/module_system.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/module_system.cc View 16 chunks +54 lines, -49 lines 0 comments Download
M chrome/renderer/extensions/object_backed_native_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/page_actions_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/runtime_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/scoped_persistent.h View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/send_request_natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/set_icon_natives.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/unsafe_persistent.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/v8_schema_registry.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/webrtc_native_handler.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/webstore_bindings.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jochen (gone - plz use gerrit)
7 years ago (2013-12-02 13:30:23 UTC) #1
jochen (gone - plz use gerrit)
Joi, please have a look at PRESUBMIT.py Marja, rest
7 years ago (2013-12-02 13:31:20 UTC) #2
marja
https://codereview.chromium.org/98543004/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/98543004/diff/1/PRESUBMIT.py#newcode838 PRESUBMIT.py:838: r"^chrome[\\\/]renderer[\\\\/]extensions[\\\/]" What's this, and why? https://codereview.chromium.org/98543004/diff/1/chrome/renderer/extensions/module_system.cc File chrome/renderer/extensions/module_system.cc (right): ...
7 years ago (2013-12-02 13:36:21 UTC) #3
jochen (gone - plz use gerrit)
https://codereview.chromium.org/98543004/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/98543004/diff/1/PRESUBMIT.py#newcode838 PRESUBMIT.py:838: r"^chrome[\\\/]renderer[\\\\/]extensions[\\\/]" On 2013/12/02 13:36:21, marja wrote: > What's this, ...
7 years ago (2013-12-02 13:45:12 UTC) #4
marja
lgtm
7 years ago (2013-12-02 13:46:20 UTC) #5
Jói
https://codereview.chromium.org/98543004/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/98543004/diff/1/PRESUBMIT.py#newcode838 PRESUBMIT.py:838: r"^chrome[\\\/]renderer[\\\\/]extensions[\\\/]" \\\\ -> \\\ (middle one)
7 years ago (2013-12-02 13:48:32 UTC) #6
jochen (gone - plz use gerrit)
done
7 years ago (2013-12-02 14:20:53 UTC) #7
Jói
LGTM
7 years ago (2013-12-02 14:30:03 UTC) #8
jochen (gone - plz use gerrit)
7 years ago (2013-12-02 14:30:35 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 manually as r238095 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698