Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: chrome/renderer/extensions/binding_generating_native_handler.cc

Issue 98543004: Remove usage of deprecated V8 APIs from c/r/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/app_bindings.cc ('k') | chrome/renderer/extensions/chrome_v8_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/binding_generating_native_handler.cc
diff --git a/chrome/renderer/extensions/binding_generating_native_handler.cc b/chrome/renderer/extensions/binding_generating_native_handler.cc
index 5fdc5a4cd711b3bc2f8f7e5d5311e08978773d29..6a4a3513e74ac13c80c46d2fe639bb66c2ad74a5 100644
--- a/chrome/renderer/extensions/binding_generating_native_handler.cc
+++ b/chrome/renderer/extensions/binding_generating_native_handler.cc
@@ -19,7 +19,7 @@ BindingGeneratingNativeHandler::BindingGeneratingNativeHandler(
v8::Handle<v8::Object> BindingGeneratingNativeHandler::NewInstance() {
v8::Isolate* isolate = module_system_->GetIsolate();
- v8::HandleScope scope(isolate);
+ v8::EscapableHandleScope scope(isolate);
v8::Handle<v8::Object> binding_module =
module_system_->Require("binding")->ToObject();
v8::Handle<v8::Object> binding = binding_module
@@ -32,14 +32,14 @@ v8::Handle<v8::Object> BindingGeneratingNativeHandler::NewInstance() {
create_binding->Call(binding, arraysize(argv), argv)->ToObject();
v8::Handle<v8::Function> generate = binding_instance
->Get(v8::String::NewFromUtf8(isolate, "generate")).As<v8::Function>();
- v8::Handle<v8::Object> object = v8::Object::New();
+ v8::Local<v8::Object> object = v8::Object::New();
v8::Handle<v8::Value> compiled_schema =
generate->Call(binding_instance, 0, NULL);
if (!compiled_schema.IsEmpty()) {
object->Set(v8::String::NewFromUtf8(isolate, bind_to_.c_str()),
compiled_schema);
}
- return scope.Close(object);
+ return scope.Escape(object);
}
} // namespace extensions
« no previous file with comments | « chrome/renderer/extensions/app_bindings.cc ('k') | chrome/renderer/extensions/chrome_v8_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698