Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/test/chromedriver/performance_logger_unittest.cc

Issue 985243002: [chromedriver] Disable Timeline by default in performance logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix unit tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/capabilities_unittest.cc ('k') | chrome/test/chromedriver/test/run_py_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/performance_logger_unittest.cc
diff --git a/chrome/test/chromedriver/performance_logger_unittest.cc b/chrome/test/chromedriver/performance_logger_unittest.cc
index 190fb5e9682b2ee4f6c8b661987e7ad44ca8c67a..bf696386bcae218d4bb02a6ff83b61a678bc14c6 100644
--- a/chrome/test/chromedriver/performance_logger_unittest.cc
+++ b/chrome/test/chromedriver/performance_logger_unittest.cc
@@ -171,7 +171,6 @@ void ExpectCommand(FakeDevToolsClient& client, const std::string& method) {
void ExpectEnableDomains(FakeDevToolsClient& client) {
ExpectCommand(client, "Network.enable");
ExpectCommand(client, "Page.enable");
- ExpectCommand(client, "Timeline.start");
}
} // namespace
@@ -215,11 +214,11 @@ TEST(PerformanceLogger, TwoWebViews) {
ASSERT_FALSE(client2.PopSentCommand(&cmd));
ASSERT_EQ(kOk, client1.TriggerEvent("Page.gaga1").code());
- ASSERT_EQ(kOk, client2.TriggerEvent("Timeline.gaga2").code());
+ ASSERT_EQ(kOk, client2.TriggerEvent("Network.gaga2").code());
ASSERT_EQ(2u, log.GetEntries().size());
ValidateLogEntry(log.GetEntries()[0], "webview-1", "Page.gaga1");
- ValidateLogEntry(log.GetEntries()[1], "webview-2", "Timeline.gaga2");
+ ValidateLogEntry(log.GetEntries()[1], "webview-2", "Network.gaga2");
}
TEST(PerformanceLogger, PerfLoggingPrefs) {
« no previous file with comments | « chrome/test/chromedriver/capabilities_unittest.cc ('k') | chrome/test/chromedriver/test/run_py_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698