Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5712)

Unified Diff: chrome/test/chromedriver/test/run_py_tests.py

Issue 985243002: [chromedriver] Disable Timeline by default in performance logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix unit tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/performance_logger_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/test/run_py_tests.py
diff --git a/chrome/test/chromedriver/test/run_py_tests.py b/chrome/test/chromedriver/test/run_py_tests.py
index d64b0a9703e0fc702c90bf7ccba0795a3025ab89..a56389d0db6f468d0d3bb031b4a0e9b7e3bc12ba 100755
--- a/chrome/test/chromedriver/test/run_py_tests.py
+++ b/chrome/test/chromedriver/test/run_py_tests.py
@@ -1239,7 +1239,6 @@ class PerformanceLoggerTest(ChromeDriverBaseTest):
def testPerformanceLogger(self):
driver = self.CreateDriver(
experimental_options={'perfLoggingPrefs': {
- 'enableTimeline': True,
'traceCategories': 'webkit.console,blink.console'
}}, performance_log_level='ALL')
driver.Load(
@@ -1268,7 +1267,7 @@ class PerformanceLoggerTest(ChromeDriverBaseTest):
self.assertTrue(devtools_message['params']['name'] == 'foobar')
marked_timeline_events.append(devtools_message)
self.assertEquals(2, len(marked_timeline_events))
- self.assertEquals({'Network', 'Page', 'Timeline', 'Tracing'},
+ self.assertEquals({'Network', 'Page', 'Tracing'},
set(seen_log_domains.keys()))
« no previous file with comments | « chrome/test/chromedriver/performance_logger_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698