Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 985243002: [chromedriver] Disable Timeline by default in performance logs (Closed)

Created:
5 years, 9 months ago by samuong
Modified:
5 years, 4 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org, stgao, klm
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Disable Timeline by default in performance logs BUG= TBR=stgao@chromium.org Committed: https://crrev.com/547831fb0f49045bf3af52482ee4ce1f58a832f2 Cr-Commit-Position: refs/heads/master@{#319582}

Patch Set 1 #

Patch Set 2 : add a todo comment #

Patch Set 3 : fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/test/chromedriver/capabilities.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/capabilities.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/capabilities_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/performance_logger_unittest.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/test/run_py_tests.py View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
samuong
Timeline support has been removed in recent builds, so we should disable this by default. ...
5 years, 9 months ago (2015-03-07 01:29:34 UTC) #2
samuong
TBR'ing to fix waterfall breakage.
5 years, 9 months ago (2015-03-07 01:40:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985243002/20001
5 years, 9 months ago (2015-03-07 01:42:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/34294)
5 years, 9 months ago (2015-03-07 03:27:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985243002/40001
5 years, 9 months ago (2015-03-07 05:07:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 07:08:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985243002/40001
5 years, 9 months ago (2015-03-08 06:20:13 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-08 06:45:40 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/547831fb0f49045bf3af52482ee4ce1f58a832f2 Cr-Commit-Position: refs/heads/master@{#319582}
5 years, 9 months ago (2015-03-08 06:46:25 UTC) #15
stgao
5 years, 4 months ago (2015-08-18 00:02:07 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698