Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 985133002: Remove NativeWebContentsModalDialog and NativePopup typedefs. (Closed)

Created:
5 years, 9 months ago by Andre
Modified:
5 years, 9 months ago
CC:
chromium-reviews, tfarina, mac-views-reviews_chromium.org, Robert Sesek, Mike Wittman
Base URL:
https://chromium.googlesource.com/chromium/src.git@extension-popup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove NativeWebContentsModalDialog and NativePopup typedefs. The typedefs in native_web_contents_modal_dialog.h are no longer needed after http://crrev.com/866263008. This change removes them, as discussed in that CL. Committed: https://crrev.com/9bae20080c1dce3ed4040b5a5638c9dc2731c2e9 Cr-Commit-Position: refs/heads/master@{#319679}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -123 lines) Patch
M chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_webui.h View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_webui.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/web_modal.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/web_modal/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D components/web_modal/native_web_contents_modal_dialog.h View 1 chunk +0 lines, -19 lines 0 comments Download
M components/web_modal/popup_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/web_modal/popup_manager.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M components/web_modal/single_popup_manager.h View 3 chunks +6 lines, -6 lines 0 comments Download
M components/web_modal/single_web_contents_dialog_manager.h View 3 chunks +8 lines, -8 lines 0 comments Download
M components/web_modal/web_contents_modal_dialog_manager.h View 4 chunks +7 lines, -7 lines 0 comments Download
M components/web_modal/web_contents_modal_dialog_manager.cc View 5 chunks +5 lines, -8 lines 0 comments Download
M components/web_modal/web_contents_modal_dialog_manager_unittest.cc View 12 chunks +21 lines, -22 lines 0 comments Download
M extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (6 generated)
Andre
As discussed, removing these typedefs.
5 years, 9 months ago (2015-03-06 21:55:40 UTC) #2
msw
lgtm, hopefully you caught all the comment mentions of those typedefs too.
5 years, 9 months ago (2015-03-06 22:28:28 UTC) #3
Mike Wittman
lgtm
5 years, 9 months ago (2015-03-06 22:35:33 UTC) #4
Andre
+derat for extensions/shell/
5 years, 9 months ago (2015-03-06 22:38:56 UTC) #6
Daniel Erat
lgtm for extensions/shell/
5 years, 9 months ago (2015-03-07 14:15:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985133002/20001
5 years, 9 months ago (2015-03-07 15:28:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/48077)
5 years, 9 months ago (2015-03-07 15:44:00 UTC) #11
Andre
+blundell for components/web_modal.gypi
5 years, 9 months ago (2015-03-07 19:34:26 UTC) #13
blundell
lgtm
5 years, 9 months ago (2015-03-09 12:58:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985133002/20001
5 years, 9 months ago (2015-03-09 17:09:27 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 17:57:23 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 17:58:56 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9bae20080c1dce3ed4040b5a5638c9dc2731c2e9
Cr-Commit-Position: refs/heads/master@{#319679}

Powered by Google App Engine
This is Rietveld 408576698