chrome/browser/ui/webui/certificate_viewer_webui.h - Issue 985133002: Remove NativeWebContentsModalDialog and NativePopup typedefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/certificate_viewer_webui.h

Issue 985133002: Remove NativeWebContentsModalDialog and NativePopup typedefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extension-popup

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc ('k') | chrome/browser/ui/webui/certificate_viewer_webui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/certificate_viewer_webui.h

diff --git a/chrome/browser/ui/webui/certificate_viewer_webui.h b/chrome/browser/ui/webui/certificate_viewer_webui.h

index 0a0531a571c8ef3c4d75a10d4e8fa197c9cb7523..367f4510cf27523c3ec33665a0e2d115d27dc07b 100644

--- a/chrome/browser/ui/webui/certificate_viewer_webui.h

+++ b/chrome/browser/ui/webui/certificate_viewer_webui.h

@@ -10,7 +10,6 @@

#include "base/compiler_specific.h"

#include "base/values.h"

-#include "components/web_modal/native_web_contents_modal_dialog.h"

#include "content/public/browser/web_ui_message_handler.h"

#include "net/cert/x509_certificate.h"

#include "ui/gfx/native_widget_types.h"

@@ -36,8 +35,7 @@ class CertificateViewerModalDialog : public ui::WebDialogDelegate {

virtual void Show(content::WebContents* web_contents,

gfx::NativeWindow parent);

- virtual web_modal::NativeWebContentsModalDialog

- GetNativeWebContentsModalDialog();

+ virtual gfx::NativeWindow GetNativeWebContentsModalDialog();

const content::WebUI* GetWebUI() const { return webui_; }

protected:

@@ -83,8 +81,7 @@ class CertificateViewerDialog : public CertificateViewerModalDialog {

// CertificateViewerModalDialog overrides.

void Show(content::WebContents* web_contents,

gfx::NativeWindow parent) override;

- web_modal::NativeWebContentsModalDialog GetNativeWebContentsModalDialog()

- override;

+ gfx::NativeWindow GetNativeWebContentsModalDialog() override;

protected:

// Overridden from ui::WebDialogDelegate: