Issue 98513003: drive: Support offline move/rename

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98513003: drive: Support offline move/rename (Closed)

Created:
7 years ago by hashimoto

Modified:
7 years ago

Reviewers:
kinaba

CC:
chromium-reviews, tim+watch_chromium.org, nkostylev+watch_chromium.org, tzik, tfarina, haitaol+watch_chromium.org, nhiroki, oshima+watch_chromium.org, kinuko+watch, rsimha+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Support offline move/rename MoveOperation is only responsible to update local data and mark it as dirty. SyncClient checks ResourceEntry::metadata_edit_state to collect back logs. EntryUpdatePerformer checks special resource IDs before making requests, it also retries update if the entry was updated again. BUG=260538 TEST=unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238066

Patch Set 1 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+138 lines, -247 lines)			Patch
M	chrome/browser/chromeos/drive/file_system.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/copy_operation.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/move_operation.h	View	3 chunks	+7 lines, -23 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/move_operation.cc	View	3 chunks	+55 lines, -129 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc	View	5 chunks	+4 lines, -84 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync/entry_update_performer.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync/entry_update_performer.cc	View	3 chunks	+33 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync_client.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync_client_unittest.cc	View	4 chunks	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hashimoto

7 years ago (2013-12-02 10:35:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r238066 (presubmit successful).

Expand Messages | Collapse Messages