Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 985113002: ServiceWorker: coalesce all SWClientInfo request into one task. (Closed)

Created:
5 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+watch, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@relax_sw_openWindow
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: coalesce all SWClientInfo request into one task. GetClientDocuments is posting on task to the UI thread for every clients it is currently controlling. This is coalescing the requests into one task in order to reduce resource usage. This also gives a better snapshot of the clients state given that all the information are gathered during the same event loop iteration. BUG=None Committed: https://crrev.com/f1bb037074fde50988ca08e9c67e445fd37a8402 Cr-Commit-Position: refs/heads/master@{#319572}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -88 lines) Patch
M content/browser/service_worker/service_worker_provider_host.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 3 chunks +24 lines, -23 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 4 chunks +60 lines, -60 lines 1 comment Download

Messages

Total messages: 28 (12 generated)
mlamouri (slow - plz ping)
5 years, 9 months ago (2015-03-06 17:51:35 UTC) #2
michaeln
lgtm, ty! Maybe massage the CL desc to mention another reason too, by gathering all ...
5 years, 9 months ago (2015-03-06 23:54:51 UTC) #3
michaeln
https://codereview.chromium.org/985113002/diff/1/content/browser/service_worker/service_worker_version.cc File content/browser/service_worker/service_worker_version.cc (right): https://codereview.chromium.org/985113002/diff/1/content/browser/service_worker/service_worker_version.cc#newcode258 content/browser/service_worker/service_worker_version.cc:258: // The tuple contains process_id, frame_id, client_id. nice comment
5 years, 9 months ago (2015-03-06 23:55:23 UTC) #4
kinuko
Was just going to make the same change... ty, drive-by lgtm 2
5 years, 9 months ago (2015-03-07 04:44:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985113002/1
5 years, 9 months ago (2015-03-07 04:46:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 06:46:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985113002/1
5 years, 9 months ago (2015-03-07 14:28:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985113002/1
5 years, 9 months ago (2015-03-07 14:33:07 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 16:28:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985113002/1
5 years, 9 months ago (2015-03-07 16:39:10 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 18:39:45 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985113002/1
5 years, 9 months ago (2015-03-07 18:41:29 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 20:42:04 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985113002/1
5 years, 9 months ago (2015-03-08 00:00:06 UTC) #26
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-08 03:53:05 UTC) #27
commit-bot: I haz the power
5 years, 9 months ago (2015-03-08 03:54:07 UTC) #28
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1bb037074fde50988ca08e9c67e445fd37a8402
Cr-Commit-Position: refs/heads/master@{#319572}

Powered by Google App Engine
This is Rietveld 408576698