content/browser/service_worker/service_worker_version.h - Issue 985113002: ServiceWorker: coalesce all SWClientInfo request into one task.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 985113002: ServiceWorker: coalesce all SWClientInfo request into one task. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@relax_sw_openWindow

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_provider_host.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | content/browser/service_worker/service_worker_version.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index bb6efbf3ce84944c5891e585b0c9c51bfe3ea0cf..5911541ea79f144e5f2ea0cba3754cc0135f1ad2 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -298,8 +298,6 @@ class CONTENT_EXPORT ServiceWorkerVersion

const net::HttpResponseInfo* GetMainScriptHttpResponseInfo();

private:

- class GetClientDocumentsCallback;

friend class base::RefCounted<ServiceWorkerVersion>;

friend class ServiceWorkerURLRequestJobTest;

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerControlleeRequestHandlerTest,

@@ -389,9 +387,8 @@ class CONTENT_EXPORT ServiceWorkerVersion

void DidSkipWaiting(int request_id);

void DidClaimClients(int request_id, ServiceWorkerStatusCode status);

- void DidGetClientInfo(int client_id,

- scoped_refptr<GetClientDocumentsCallback> callback,

- const ServiceWorkerClientInfo& info);

+ void DidGetClientDocuments(

+ int request_id, const std::vector<ServiceWorkerClientInfo>& clients);

// The timeout timer periodically calls OnTimeoutTimer, which stops the worker

// if it is excessively idle or unresponsive to ping.