Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 985003003: Make Sk4f(float) constructor explicit. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make Sk4f(float) constructor explicit. BUG=skia: Committed: https://skia.googlesource.com/skia/+/a27cdefae19d1d40e6a9ca84935c72bde48236b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/core/Sk4x.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/PMFloatTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/Sk4xTest.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein_C
5 years, 9 months ago (2015-03-06 16:00:21 UTC) #2
reed1
lgtm
5 years, 9 months ago (2015-03-06 16:59:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985003003/1
5 years, 9 months ago (2015-03-06 18:02:59 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-07 00:20:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a27cdefae19d1d40e6a9ca84935c72bde48236b3

Powered by Google App Engine
This is Rietveld 408576698