src/core/Sk4x.h - Issue 985003003: Make Sk4f(float) constructor explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/Sk4x.h

Issue 985003003: Make Sk4f(float) constructor explicit. (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/Sk4x.h

diff --git a/src/core/Sk4x.h b/src/core/Sk4x.h

index 01ce39f074d896e43979cbaaee9d420a45a1eca9..0b9796db9b9bb1e42ee23606e27f3f9deeb4952a 100644

--- a/src/core/Sk4x.h

+++ b/src/core/Sk4x.h

@@ -25,7 +25,7 @@ typedef Sk4x<int32_t> Sk4i;

template <typename T> class Sk4x {

public:

Sk4x(); // Uninitialized; use Sk4x(0) for zero.

- /*implicit*/ Sk4x(T); // Same as Sk4x(T,T,T,T);

+ explicit Sk4x(T); // Same as Sk4x(T,T,T,T);

Sk4x(T, T, T, T);

Sk4x(const Sk4x&);

« no previous file with comments | « no previous file | tests/PMFloatTest.cpp » ('j') | no next file with comments »