Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 98493003: Simplify fileBrowserPrivate.getDriveConnectionStatus(). (Closed)

Created:
7 years ago by kinaba
Modified:
7 years ago
Reviewers:
yoshiki, benwells
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Simplify fileBrowserPrivate.getDriveConnectionStatus(). The "reasons" field had been a subset of {NO_SERVICE, NO_NETWORK, NOT_READY}, but it is now used only for signaling errors when it has NOT_READY without other reasons. This can more simply be represented by a single "reason" field whose value is set in the order: NO_SERVICE > NO_NETWORK > NOT_READY, i.e., NOT_READY is set only when other two states are not set. BUG=237427 R=benwells@chromium.org, yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238318

Patch Set 1 #

Patch Set 2 : Fix the util function name. #

Messages

Total messages: 8 (0 generated)
kinaba
yoshiki: everything. benwells: on the private api json change.
7 years ago (2013-12-02 07:42:33 UTC) #1
kinaba
On 2013/12/02 07:42:33, kinaba wrote: > yoshiki: everything. > benwells: on the private api json ...
7 years ago (2013-12-02 07:52:42 UTC) #2
benwells
.json lgtm
7 years ago (2013-12-02 21:18:22 UTC) #3
yoshiki
lgtm
7 years ago (2013-12-03 02:38:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/98493003/20001
7 years ago (2013-12-03 02:48:59 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195908
7 years ago (2013-12-03 05:54:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/98493003/20001
7 years ago (2013-12-03 05:55:49 UTC) #7
kinaba
7 years ago (2013-12-03 07:38:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r238318 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698