chrome/browser/resources/file_manager/foreground/js/drive_banners.js - Issue 98493003: Simplify fileBrowserPrivate.getDriveConnectionStatus().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/file_manager/foreground/js/drive_banners.js

Issue 98493003: Simplify fileBrowserPrivate.getDriveConnectionStatus(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix the util function name. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/file_manager/common/js/util.js ('k') | chrome/browser/resources/file_manager/foreground/js/volume_manager_wrapper.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/file_manager/foreground/js/drive_banners.js

diff --git a/chrome/browser/resources/file_manager/foreground/js/drive_banners.js b/chrome/browser/resources/file_manager/foreground/js/drive_banners.js

index 9149befe51ff499a7d789c1748f107bd16e7bcb8..25692c8e727bd79dc2fb0134f7ce77290a40b0ff 100644

--- a/chrome/browser/resources/file_manager/foreground/js/drive_banners.js

+++ b/chrome/browser/resources/file_manager/foreground/js/drive_banners.js

@@ -653,13 +653,9 @@ FileListBannerController.prototype.updateDriveUnmountedPanel_ = function() {

FileListBannerController.prototype.maybeShowAuthFailBanner_ = function() {

var connection = this.volumeManager_.getDriveConnectionState();

- var reasons = connection.reasons;

var showDriveNotReachedMessage =

this.isOnCurrentProfileDrive() &&

connection.type == util.DriveConnectionType.OFFLINE &&

- // Show the banner only when authentication fails. Don't show it when the

- // drive service is disabled.

- reasons.indexOf(util.DriveConnectionReason.NOT_READY) != -1 &&

- reasons.indexOf(util.DriveConnectionReason.NO_SERVICE) == -1;

+ connection.reason == util.DriveConnectionReason.NOT_READY;

this.authFailedBanner_.hidden = !showDriveNotReachedMessage;

};