Issue 984783002: Merge to XFA: Make conversion between CPDF_Action and its dictionary explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 984783002: Merge to XFA: Make conversion between CPDF_Action and its dictionary explicit. (Closed)

Created:
5 years, 9 months ago by Tom Sepez

Modified:
5 years, 9 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+205 lines, -245 lines)			Patch
M	core/include/fpdfdoc/fpdf_doc.h	View	3 chunks	+8 lines, -12 lines	0 comments	Download
M	core/src/fpdfdoc/doc_action.cpp	View	8 chunks	+32 lines, -30 lines	0 comments	Download
M	core/src/fpdfdoc/doc_bookmark.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	core/src/fpdfdoc/doc_formcontrol.cpp	View	1 chunk	+8 lines, -9 lines	0 comments	Download
M	core/src/fpdfdoc/doc_link.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/fpdfdoc.cpp	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	fpdfsdk/src/fsdk_actionhandler.cpp	View	22 chunks	+100 lines, -114 lines	0 comments	Download
M	fpdfsdk/src/fsdk_baseannot.cpp	View	2 chunks	+13 lines, -29 lines	0 comments	Download
M	fpdfsdk/src/fsdk_baseform.cpp	View	4 chunks	+12 lines, -21 lines	0 comments	Download
M	fpdfsdk/src/fsdk_mgr.cpp	View	1 chunk	+24 lines, -22 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

5 years, 9 months ago (2015-03-06 00:44:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7b5bc26e8267fec38bef9f95cd04d2bd731faff3 (presubmit successful).