core/src/fpdfdoc/doc_bookmark.cpp - Issue 984783002: Merge to XFA: Make conversion between CPDF_Action and its dictionary explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfdoc/doc_bookmark.cpp

Issue 984783002: Merge to XFA: Make conversion between CPDF_Action and its dictionary explicit. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fpdfdoc/doc_bookmark.cpp

diff --git a/core/src/fpdfdoc/doc_bookmark.cpp b/core/src/fpdfdoc/doc_bookmark.cpp

index e7b383eced7201b6ffd5fb1374fe21c5bd1adca7..a3a194337e1d92244a081e27931866186349dba7 100644

--- a/core/src/fpdfdoc/doc_bookmark.cpp

+++ b/core/src/fpdfdoc/doc_bookmark.cpp

@@ -86,7 +86,7 @@ CPDF_Dest CPDF_Bookmark::GetDest(CPDF_Document* pDocument) const

CPDF_Action CPDF_Bookmark::GetAction() const

{

if (!m_pDict) {

- return NULL;

+ return CPDF_Action();

}

- return m_pDict->GetDict("A");

+ return CPDF_Action(m_pDict->GetDict("A"));

}

« no previous file with comments | « core/src/fpdfdoc/doc_action.cpp ('k') | core/src/fpdfdoc/doc_formcontrol.cpp » ('j') | no next file with comments »