src/untrusted/irt/irt_interfaces.c - Issue 984713003: Add an IRT interface for subzero/compiler to serve_translate_requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/untrusted/irt/irt_interfaces.c

Issue 984713003: Add an IRT interface for subzero/compiler to serve_translate_requests. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: add a log_fatal for now, to marshal back Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/untrusted/irt/irt_interfaces.c

diff --git a/src/untrusted/irt/irt_interfaces.c b/src/untrusted/irt/irt_interfaces.c

index 44a22b6433aaa86da93151b35be29b655d703c78..ac2c742b1ce46db63f4dda8a94bc888f28342a45 100644

--- a/src/untrusted/irt/irt_interfaces.c

+++ b/src/untrusted/irt/irt_interfaces.c

@@ -135,6 +135,14 @@ static const struct nacl_irt_interface irt_interfaces[] = {

{ NACL_IRT_PRIVATE_PNACL_TRANSLATOR_LINK_v0_1,

&nacl_irt_private_pnacl_translator_link,

sizeof(nacl_irt_private_pnacl_translator_link), NULL },

+ /*

+ * TODO(jvoung): Similar to NACL_IRT_PRIVATE_PNACL_TRANSLATOR_LINK_v0_1

+ * ideally this should be hidden from non-translator apps.

+ */

+ { NACL_IRT_PRIVATE_PNACL_TRANSLATOR_SUBZERO_v0_1,

+ &nacl_irt_private_pnacl_translator_subzero,

+ sizeof(nacl_irt_private_pnacl_translator_subzero), NULL },

Mark Seaborn 2015/03/23 18:15:56 Nit: remove empty line

jvoung (off chromium) 2015/03/23 21:18:55 Done.

};

size_t nacl_irt_query_core(const char *interface_ident,

« src/untrusted/irt/irt_dev.h ('K') | « src/untrusted/irt/irt_interfaces.h ('k') | src/untrusted/irt/irt_pnacl_translator.c » ('j') | src/untrusted/irt/irt_pnacl_translator_subzero.c » ('J')