Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: src/untrusted/irt/irt_interfaces.c

Issue 984713003: Add an IRT interface for subzero/compiler to serve_translate_requests. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: add a log_fatal for now, to marshal back Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The Native Client Authors. All rights reserved. 2 * Copyright (c) 2012 The Native Client Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 #include <string.h> 7 #include <string.h>
8 8
9 #include "native_client/src/include/nacl_compiler_annotations.h" 9 #include "native_client/src/include/nacl_compiler_annotations.h"
10 #include "native_client/src/include/nacl_macros.h" 10 #include "native_client/src/include/nacl_macros.h"
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 * TODO(mseaborn): Ideally this interface should be hidden in processes 128 * TODO(mseaborn): Ideally this interface should be hidden in processes
129 * that aren't PNaCl sandboxed translator processes. However, we haven't 129 * that aren't PNaCl sandboxed translator processes. However, we haven't
130 * yet plumbed though a flag to indicate when a NaCl process is a PNaCl 130 * yet plumbed though a flag to indicate when a NaCl process is a PNaCl
131 * translator process. The risk of an app accidentally depending on the 131 * translator process. The risk of an app accidentally depending on the
132 * presence of this interface is much lower than for other non-stable IRT 132 * presence of this interface is much lower than for other non-stable IRT
133 * interfaces, because this interface is not useful to apps. 133 * interfaces, because this interface is not useful to apps.
134 */ 134 */
135 { NACL_IRT_PRIVATE_PNACL_TRANSLATOR_LINK_v0_1, 135 { NACL_IRT_PRIVATE_PNACL_TRANSLATOR_LINK_v0_1,
136 &nacl_irt_private_pnacl_translator_link, 136 &nacl_irt_private_pnacl_translator_link,
137 sizeof(nacl_irt_private_pnacl_translator_link), NULL }, 137 sizeof(nacl_irt_private_pnacl_translator_link), NULL },
138 /*
139 * TODO(jvoung): Similar to NACL_IRT_PRIVATE_PNACL_TRANSLATOR_LINK_v0_1
140 * ideally this should be hidden from non-translator apps.
141 */
142 { NACL_IRT_PRIVATE_PNACL_TRANSLATOR_SUBZERO_v0_1,
143 &nacl_irt_private_pnacl_translator_subzero,
144 sizeof(nacl_irt_private_pnacl_translator_subzero), NULL },
145
Mark Seaborn 2015/03/23 18:15:56 Nit: remove empty line
jvoung (off chromium) 2015/03/23 21:18:55 Done.
138 }; 146 };
139 147
140 size_t nacl_irt_query_core(const char *interface_ident, 148 size_t nacl_irt_query_core(const char *interface_ident,
141 void *table, size_t tablesize) { 149 void *table, size_t tablesize) {
142 return nacl_irt_query_list(interface_ident, table, tablesize, 150 return nacl_irt_query_list(interface_ident, table, tablesize,
143 irt_interfaces, sizeof(irt_interfaces)); 151 irt_interfaces, sizeof(irt_interfaces));
144 } 152 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698