Chromecast: implement other MediaKeys interfaces in BrowserCdmCast.

chromecast/media/cdm/browser_cdm_cast.cc

Index: chromecast/media/cdm/browser_cdm_cast.cc
diff --git a/chromecast/media/cdm/browser_cdm_cast.cc b/chromecast/media/cdm/browser_cdm_cast.cc
index ded9448892a3f797c188aea8bbac775be2a9d884..dde7fa2203cf68b401078044c3dba4baf5f2a96b 100644
--- a/chromecast/media/cdm/browser_cdm_cast.cc
+++ b/chromecast/media/cdm/browser_cdm_cast.cc
@@ -57,6 +57,22 @@ void BrowserCdmCast::UnregisterPlayer(int registration_id) {
   cdm_unset_callbacks_.erase(registration_id);
 }
 
+void BrowserCdmCast::LoadSession(
+    ::media::MediaKeys::SessionType session_type,
+    const std::string& session_id,
+    scoped_ptr<::media::NewSessionCdmPromise> promise) {
+  NOTIMPLEMENTED() << "LoadSession not supported";

[ddorwin, 2015/03/05 20:59:57]

I think maybe this should be a DCHECK. At least in unprefixed EME, we should
prevent this from being called if you don't register support for "persistent-*"
session types.

[gunsch, 2015/03/05 21:12:49]

Changed to a NOTREACHED.

+  session_error_cb_.Run(session_id,
+                        ::media::MediaKeys::Exception::NOT_SUPPORTED_ERROR,
+                        0,
+                        std::string());
+}
+
+::media::CdmContext* BrowserCdmCast::GetCdmContext() {
+  NOTREACHED();

[ddorwin, 2015/03/05 20:59:57]

Are you sure this is not reachable? I thought this had to be implemented and
return a valid value from one of the member methods.
+xhwang

[xhwang, 2015/03/05 21:12:39]

This is okay and is actually what MediaDrmBridge is doing. MediaSourcePlayer
uses MediaDrmBridge directly and is not using the CdmContext:
https://code.google.com/p/chromium/codesearch#chromium/src/media/base/android...

[gunsch, 2015/03/05 21:12:49]

MediaDrmBridge does the same:

https://code.google.com/p/chromium/codesearch#chromium/src/media/base/android...

+  return nullptr;
+}
+
 void BrowserCdmCast::OnSessionMessage(const std::string& session_id,
                                       const std::vector<uint8>& message,
                                       const GURL& destination_url) {