Chromecast: implement other MediaKeys interfaces in BrowserCdmCast.

chromecast/media/cdm/browser_cdm_cast.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/media/cdm/browser_cdm_cast.h"
 
 #include "media/base/cdm_key_information.h"
 
 namespace chromecast {
 namespace media {
@@ skipping 39 matching lines @@
 }
 
 void BrowserCdmCast::UnregisterPlayer(int registration_id) {
   base::AutoLock auto_lock(callback_lock_);
   DCHECK(ContainsKey(new_key_callbacks_, registration_id));
   DCHECK(ContainsKey(cdm_unset_callbacks_, registration_id));
   new_key_callbacks_.erase(registration_id);
   cdm_unset_callbacks_.erase(registration_id);
 }
 
+void BrowserCdmCast::LoadSession(
+    ::media::MediaKeys::SessionType session_type,
+    const std::string& session_id,
+    scoped_ptr<::media::NewSessionCdmPromise> promise) {
+  NOTIMPLEMENTED() << "LoadSession not supported";

[ddorwin, 2015/03/05 20:59:57]

I think maybe this should be a DCHECK. At least in unprefixed EME, we should
prevent this from being called if you don't register support for "persistent-*"
session types.

[gunsch, 2015/03/05 21:12:49]

Changed to a NOTREACHED.

+  session_error_cb_.Run(session_id,
+                        ::media::MediaKeys::Exception::NOT_SUPPORTED_ERROR,
+                        0,
+                        std::string());
+}
+
+::media::CdmContext* BrowserCdmCast::GetCdmContext() {
+  NOTREACHED();

[ddorwin, 2015/03/05 20:59:57]

Are you sure this is not reachable? I thought this had to be implemented and
return a valid value from one of the member methods.
+xhwang

[xhwang, 2015/03/05 21:12:39]

This is okay and is actually what MediaDrmBridge is doing. MediaSourcePlayer
uses MediaDrmBridge directly and is not using the CdmContext:
https://code.google.com/p/chromium/codesearch#chromium/src/media/base/android...

[gunsch, 2015/03/05 21:12:49]

MediaDrmBridge does the same:

https://code.google.com/p/chromium/codesearch#chromium/src/media/base/android...

+  return nullptr;
+}
+
 void BrowserCdmCast::OnSessionMessage(const std::string& session_id,
                                       const std::vector<uint8>& message,
                                       const GURL& destination_url) {
   // Note: Message type is not supported in Chromecast. Do our best guess here.
   ::media::MediaKeys::MessageType message_type =
       destination_url.is_empty() ? ::media::MediaKeys::LICENSE_REQUEST
                                  : ::media::MediaKeys::LICENSE_RENEWAL;
   session_message_cb_.Run(session_id,
                           message_type,
                           message,
@@ skipping 21 matching lines @@
     base::AutoLock auto_lock(callback_lock_);
     for (std::map<uint32_t, base::Closure>::const_iterator it =
          new_key_callbacks_.begin(); it != new_key_callbacks_.end(); ++it) {
       it->second.Run();
     }
   }
 }
 
 }  // namespace media
 }  // namespace chromecast