Chromecast: implement other MediaKeys interfaces in BrowserCdmCast.

Chromecast: implement other MediaKeys interfaces in BrowserCdmCast.

R=derekjchow@chromium.org,lcwu@chromium.org
BUG=internal b/19003955

Committed: https://crrev.com/5aabb3fb79526ba574f1a0b91273af1d990570e2
Cr-Commit-Position: refs/heads/master@{#319346}

[ddorwin, 2015-03-05 20:59:56]

ddorwin@chromium.org changed reviewers:
+ ddorwin@chromium.org, xhwang@chromium.org

[ddorwin, 2015-03-05 20:59:57]

https://codereview.chromium.org/984693002/diff/1/chromecast/media/cdm/browser...
File chromecast/media/cdm/browser_cdm_cast.cc (right):

https://codereview.chromium.org/984693002/diff/1/chromecast/media/cdm/browser...
chromecast/media/cdm/browser_cdm_cast.cc:64: NOTIMPLEMENTED() << "LoadSession
not supported";
I think maybe this should be a DCHECK. At least in unprefixed EME, we should
prevent this from being called if you don't register support for "persistent-*"
session types.

https://codereview.chromium.org/984693002/diff/1/chromecast/media/cdm/browser...
chromecast/media/cdm/browser_cdm_cast.cc:72: NOTREACHED();
Are you sure this is not reachable? I thought this had to be implemented and
return a valid value from one of the member methods.
+xhwang

[xhwang, 2015-03-05 21:12:39]

https://codereview.chromium.org/984693002/diff/1/chromecast/media/cdm/browser...
File chromecast/media/cdm/browser_cdm_cast.cc (right):

https://codereview.chromium.org/984693002/diff/1/chromecast/media/cdm/browser...
chromecast/media/cdm/browser_cdm_cast.cc:72: NOTREACHED();
On 2015/03/05 20:59:57, ddorwin wrote:
> Are you sure this is not reachable? I thought this had to be implemented and
> return a valid value from one of the member methods.
> +xhwang

This is okay and is actually what MediaDrmBridge is doing. MediaSourcePlayer
uses MediaDrmBridge directly and is not using the CdmContext:
https://code.google.com/p/chromium/codesearch#chromium/src/media/base/android...

[gunsch, 2015-03-05 21:12:49]

https://codereview.chromium.org/984693002/diff/1/chromecast/media/cdm/browser...
File chromecast/media/cdm/browser_cdm_cast.cc (right):

https://codereview.chromium.org/984693002/diff/1/chromecast/media/cdm/browser...
chromecast/media/cdm/browser_cdm_cast.cc:64: NOTIMPLEMENTED() << "LoadSession
not supported";
On 2015/03/05 20:59:57, ddorwin wrote:
> I think maybe this should be a DCHECK. At least in unprefixed EME, we should
> prevent this from being called if you don't register support for
"persistent-*"
> session types.

Changed to a NOTREACHED.

https://codereview.chromium.org/984693002/diff/1/chromecast/media/cdm/browser...
chromecast/media/cdm/browser_cdm_cast.cc:72: NOTREACHED();
On 2015/03/05 20:59:57, ddorwin wrote:
> Are you sure this is not reachable? I thought this had to be implemented and
> return a valid value from one of the member methods.
> +xhwang

MediaDrmBridge does the same:

https://code.google.com/p/chromium/codesearch#chromium/src/media/base/android...

[gunsch, 2015-03-05 21:13:01]

Patchset #2 (id:20001) has been deleted

[gunsch, 2015-03-05 21:13:06]

Patchset #2 (id:40001) has been deleted

[ddorwin, 2015-03-05 21:25:11]

LG. Thanks.

[xhwang, 2015-03-05 21:29:32]

lgtm

[gunsch, 2015-03-05 21:51:55]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2015-03-05 22:00:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/984693002/60001

[lcwu1, 2015-03-05 22:02:23]

lgtm

[commit-bot: I haz the power, 2015-03-05 22:34:19]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-03-05 22:35:04]

Patchset 2 (id:??) landed as
https://crrev.com/5aabb3fb79526ba574f1a0b91273af1d990570e2
Cr-Commit-Position: refs/heads/master@{#319346}