Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 984203003: Move mocks and unittest JS files to sit alongside production code. (Closed)

Created:
5 years, 9 months ago by Wez
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move mocks and unittest JS files to sit alongside production code. Chromium normally places unit-test implementations alongside the class implementations, so that it's easy to see what has tests and what doesn't. Similarly placing mocks next to the corresponding interfaces or classes makes it easier to spot and re-use them. BUG=455972 Committed: https://crrev.com/0f92988f0ef745e9ea4b2ff68c897cb83d911469 Cr-Commit-Position: refs/heads/master@{#320296}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3595 lines) Patch
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_all.gyp View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_test.gypi View 1 2 chunks +9 lines, -9 lines 0 comments Download
M remoting/remoting_webapp.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/remoting_webapp_files.gypi View 1 2 chunks +34 lines, -34 lines 0 comments Download
D remoting/tools/run_webapp_unittest.py View 1 chunk +0 lines, -93 lines 0 comments Download
A + remoting/tools/run_webapp_unittests.py View 2 chunks +2 lines, -2 lines 0 comments Download
A + remoting/webapp/base/js/base_event_hook_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/base_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/base/js/ipc_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D remoting/webapp/browser_test/mock_client_plugin.js View 1 chunk +0 lines, -204 lines 0 comments Download
D remoting/webapp/browser_test/mock_host_list_api.js View 1 1 chunk +0 lines, -109 lines 0 comments Download
D remoting/webapp/browser_test/mock_identity.js View 1 1 chunk +0 lines, -110 lines 0 comments Download
D remoting/webapp/browser_test/mock_oauth2_api.js View 1 1 chunk +0 lines, -92 lines 0 comments Download
D remoting/webapp/browser_test/mock_session_connector.js View 1 1 chunk +0 lines, -183 lines 0 comments Download
D remoting/webapp/crd/html/template_unittest.html View 1 1 chunk +0 lines, -29 lines 0 comments Download
A + remoting/webapp/crd/html/template_unittests.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/apps_v2_migration_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/desktop_viewport_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/dns_blackhole_checker_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/fallback_signal_strategy_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/host_table_entry_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/l10n_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/menu_button_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/mock_client_plugin.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/mock_host_list_api.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/mock_identity.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/mock_oauth2_api.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/mock_session_connector.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/mock_signal_strategy.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/xhr_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/xmpp_connection_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/xmpp_login_handler_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/crd/js/xmpp_stream_parser_unittest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/webapp/js_proto/chrome_mocks.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D remoting/webapp/unittests/apps_v2_migration_unittest.js View 1 1 chunk +0 lines, -119 lines 0 comments Download
D remoting/webapp/unittests/base_unittest.js View 1 1 chunk +0 lines, -327 lines 0 comments Download
D remoting/webapp/unittests/chrome_mocks.js View 1 chunk +0 lines, -205 lines 0 comments Download
D remoting/webapp/unittests/desktop_viewport_unittest.js View 1 chunk +0 lines, -329 lines 0 comments Download
D remoting/webapp/unittests/dns_blackhole_checker_unittest.js View 1 1 chunk +0 lines, -170 lines 0 comments Download
D remoting/webapp/unittests/event_hook_unittest.js View 1 chunk +0 lines, -89 lines 0 comments Download
D remoting/webapp/unittests/fallback_signal_strategy_unittest.js View 1 chunk +0 lines, -276 lines 0 comments Download
D remoting/webapp/unittests/host_table_entry_unittest.js View 1 1 chunk +0 lines, -198 lines 0 comments Download
D remoting/webapp/unittests/ipc_unittest.js View 1 chunk +0 lines, -140 lines 0 comments Download
D remoting/webapp/unittests/l10n_unittest.js View 1 1 chunk +0 lines, -111 lines 0 comments Download
D remoting/webapp/unittests/menu_button_unittest.js View 1 chunk +0 lines, -94 lines 0 comments Download
D remoting/webapp/unittests/mock_signal_strategy.js View 1 1 chunk +0 lines, -79 lines 0 comments Download
D remoting/webapp/unittests/xhr_unittest.js View 1 chunk +0 lines, -234 lines 0 comments Download
D remoting/webapp/unittests/xmpp_connection_unittest.js View 1 1 chunk +0 lines, -103 lines 0 comments Download
D remoting/webapp/unittests/xmpp_login_handler_unittest.js View 1 chunk +0 lines, -176 lines 0 comments Download
D remoting/webapp/unittests/xmpp_stream_parser_unittest.js View 1 chunk +0 lines, -95 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Wez
PTAL This CL moves the unittest.js files alongside the production code, to match the way ...
5 years, 9 months ago (2015-03-09 19:04:24 UTC) #2
kelvinp
lgtm
5 years, 9 months ago (2015-03-09 23:06:09 UTC) #4
garykac
lgtm!
5 years, 9 months ago (2015-03-09 23:18:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984203003/1
5 years, 9 months ago (2015-03-12 00:05:39 UTC) #7
Wez
Pawel, plz rubber-stamp the BUILD.gn change (which is just to a commented-out line right now...)
5 years, 9 months ago (2015-03-12 00:18:54 UTC) #9
Paweł Hajdan Jr.
chrome/test LGTM
5 years, 9 months ago (2015-03-12 14:39:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984203003/20001
5 years, 9 months ago (2015-03-12 14:48:54 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-12 16:19:27 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 16:19:53 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f92988f0ef745e9ea4b2ff68c897cb83d911469
Cr-Commit-Position: refs/heads/master@{#320296}

Powered by Google App Engine
This is Rietveld 408576698