Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: remoting/webapp/unittests/dns_blackhole_checker_unittest.js

Issue 984203003: Move mocks and unittest JS files to sit alongside production code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/unittests/dns_blackhole_checker_unittest.js
diff --git a/remoting/webapp/unittests/dns_blackhole_checker_unittest.js b/remoting/webapp/unittests/dns_blackhole_checker_unittest.js
deleted file mode 100644
index dafa2c2bf997bf3d6c8b4c235ed7123a94928983..0000000000000000000000000000000000000000
--- a/remoting/webapp/unittests/dns_blackhole_checker_unittest.js
+++ /dev/null
@@ -1,170 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-/**
- * @fileoverview
- * TODO(garykac): Create interface for SignalStrategy.
- * @suppress {checkTypes|checkVars|reportUnknownTypes|visibility}
- */
-
-(function() {
-
-'use strict';
-
-/** @type {(sinon.Spy|function(remoting.SignalStrategy.State))} */
-var onStateChange = null;
-
-/** @type {(sinon.Spy|function(Element):void)} */
-var onIncomingStanzaCallback = null;
-
-/** @type {remoting.DnsBlackholeChecker} */
-var checker = null;
-
-/** @type {remoting.MockSignalStrategy} */
-var signalStrategy = null;
-var fakeXhrs;
-
-module('dns_blackhole_checker', {
- setup: function() {
- fakeXhrs = [];
- sinon.useFakeXMLHttpRequest().onCreate = function(xhr) {
- fakeXhrs.push(xhr);
- };
-
- onStateChange = sinon.spy();
- onIncomingStanzaCallback = sinon.spy();
- signalStrategy = new remoting.MockSignalStrategy();
- checker = new remoting.DnsBlackholeChecker(signalStrategy);
-
- checker.setStateChangedCallback(onStateChange);
- checker.setIncomingStanzaCallback(onIncomingStanzaCallback);
-
- sinon.assert.notCalled(onStateChange);
- sinon.assert.notCalled(signalStrategy.connect);
- checker.connect('server', 'username', 'authToken');
- sinon.assert.calledWith(signalStrategy.connect, 'server', 'username',
- 'authToken');
-
- QUnit.equal(fakeXhrs.length, 1, 'exactly one XHR is issued');
- QUnit.equal(
- fakeXhrs[0].url, remoting.DnsBlackholeChecker.URL_TO_REQUEST_,
- 'the correct URL is requested');
- },
- teardown: function() {
- base.dispose(checker);
- sinon.assert.calledWith(onStateChange,
- remoting.SignalStrategy.State.CLOSED);
-
- onStateChange = null;
- onIncomingStanzaCallback = null;
- checker = null;
- },
-});
-
-test('success',
- function() {
- fakeXhrs[0].respond(200);
- sinon.assert.notCalled(onStateChange);
-
- [
- remoting.SignalStrategy.State.CONNECTING,
- remoting.SignalStrategy.State.HANDSHAKE,
- remoting.SignalStrategy.State.CONNECTED
- ].forEach(function(state) {
- signalStrategy.setStateForTesting(state);
- sinon.assert.calledWith(onStateChange, state);
- equal(checker.getState(), state);
- });
- }
-);
-
-test('http response after connected',
- function() {
- [
- remoting.SignalStrategy.State.CONNECTING,
- remoting.SignalStrategy.State.HANDSHAKE,
- ].forEach(function(state) {
- signalStrategy.setStateForTesting(state);
- sinon.assert.calledWith(onStateChange, state);
- equal(checker.getState(), state);
- });
- onStateChange.reset();
-
- // Verify that DnsBlackholeChecker stays in HANDSHAKE state even if the
- // signal strategy has connected.
- signalStrategy.setStateForTesting(remoting.SignalStrategy.State.CONNECTED);
- sinon.assert.notCalled(onStateChange);
- equal(checker.getState(), remoting.SignalStrategy.State.HANDSHAKE);
-
- // Verify that DnsBlackholeChecker goes to CONNECTED state after the
- // the HTTP request has succeeded.
- fakeXhrs[0].respond(200);
- sinon.assert.calledWith(onStateChange,
- remoting.SignalStrategy.State.CONNECTED);
- }
-);
-
-test('connect failed',
- function() {
- fakeXhrs[0].respond(200);
- sinon.assert.notCalled(onStateChange);
-
- [
- remoting.SignalStrategy.State.CONNECTING,
- remoting.SignalStrategy.State.FAILED
- ].forEach(function(state) {
- signalStrategy.setStateForTesting(state);
- sinon.assert.calledWith(onStateChange, state);
- });
-}
-);
-
-test('blocked',
- function() {
- fakeXhrs[0].respond(400);
- sinon.assert.calledWith(onStateChange,
- remoting.SignalStrategy.State.FAILED);
- equal(checker.getError().tag, remoting.Error.Tag.NOT_AUTHORIZED);
- onStateChange.reset();
-
- [
- remoting.SignalStrategy.State.CONNECTING,
- remoting.SignalStrategy.State.HANDSHAKE,
- remoting.SignalStrategy.State.CONNECTED
- ].forEach(function(state) {
- signalStrategy.setStateForTesting(state);
- sinon.assert.notCalled(onStateChange);
- equal(checker.getState(), remoting.SignalStrategy.State.FAILED);
- });
- }
-);
-
-test('blocked after connected',
- function() {
- [
- remoting.SignalStrategy.State.CONNECTING,
- remoting.SignalStrategy.State.HANDSHAKE,
- ].forEach(function(state) {
- signalStrategy.setStateForTesting(state);
- sinon.assert.calledWith(onStateChange, state);
- equal(checker.getState(), state);
- });
- onStateChange.reset();
-
- // Verify that DnsBlackholeChecker stays in HANDSHAKE state even if the
- // signal strategy has connected.
- signalStrategy.setStateForTesting(remoting.SignalStrategy.State.CONNECTED);
- sinon.assert.notCalled(onStateChange);
- equal(checker.getState(), remoting.SignalStrategy.State.HANDSHAKE);
-
- // Verify that DnsBlackholeChecker goes to FAILED state after it gets the
- // blocked HTTP response.
- fakeXhrs[0].respond(400);
- sinon.assert.calledWith(onStateChange,
- remoting.SignalStrategy.State.FAILED);
- equal(checker.getError().tag, remoting.Error.Tag.NOT_AUTHORIZED);
- }
-);
-
-})();
« no previous file with comments | « remoting/webapp/unittests/desktop_viewport_unittest.js ('k') | remoting/webapp/unittests/event_hook_unittest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698