Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 984143002: Merge to XFA: Make conversion between CPDF_Dest and its object explicit. (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Merge to XFA: Make conversion between CPDF_Dest and its object explicit. Original Review URL: https://codereview.chromium.org/984703004 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ac8d1e75645d783cc72d2cfd57554e48e3ed2999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -41 lines) Patch
M core/include/fpdfdoc/fpdf_doc.h View 1 chunk +5 lines, -14 lines 0 comments Download
M core/src/fpdfdoc/doc_action.cpp View 1 chunk +10 lines, -9 lines 0 comments Download
M core/src/fpdfdoc/doc_bookmark.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M core/src/fpdfdoc/doc_link.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M fpdfsdk/src/fpdfdoc.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/fsdk_actionhandler.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
Merging.
5 years, 9 months ago (2015-03-06 18:49:43 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as ac8d1e75645d783cc72d2cfd57554e48e3ed2999 (presubmit successful).
5 years, 9 months ago (2015-03-06 18:52:10 UTC) #2
Lei Zhang
5 years, 9 months ago (2015-03-06 19:03:18 UTC) #3
Message was sent while issue was closed.
rs lgtm

Powered by Google App Engine
This is Rietveld 408576698