Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 984703004: Make conversion to CPDF_Dest explicit (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make conversion between CPDF_Dest and its object explicit. Precursor to taking a second shot at cleaning up the FPDF_* APIs. A FPDF_Dest is a CPDF_Array, and a CPDF_Dest is a structure holding a FPDF_Dest. This goes against the convention that FPDF_ types get cast to CPDF_* types, so we want to make it clear where objects are getting constructed, etc. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5a370d77d0db7550e91888f0ff50ee305f0f9f3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -41 lines) Patch
M core/include/fpdfdoc/fpdf_doc.h View 1 chunk +5 lines, -14 lines 0 comments Download
M core/src/fpdfdoc/doc_action.cpp View 1 chunk +10 lines, -9 lines 0 comments Download
M core/src/fpdfdoc/doc_bookmark.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M core/src/fpdfdoc/doc_link.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M fpdfsdk/src/fpdfdoc.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/fsdk_actionhandler.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, same stuff different class.
5 years, 9 months ago (2015-03-06 01:22:46 UTC) #2
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-06 01:27:47 UTC) #3
Tom Sepez
5 years, 9 months ago (2015-03-06 18:34:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a370d77d0db7550e91888f0ff50ee305f0f9f3d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698