Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 984103003: Revert of Reset the root layer on the compositor when recreating a root layer. (Closed)

Created:
5 years, 9 months ago by Lei Zhang
Modified:
5 years, 9 months ago
Reviewers:
danakj, sadrul, bruthig
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reset the root layer on the compositor when recreating a root layer. (patchset #3 id:40001 of https://codereview.chromium.org/983933002/) Reason for revert: Unit test forgot to callTerminateContextFactoryForTests() and leaks memory. Original issue's description: > Reset the root layer on the compositor when recreating a root layer. > > This is going to be used by https://codereview.chromium.org/975943002/ > > TEST=LayerOwnerTest.RecreateRootLayerWithNullCompositor > TEST=LayerOwnerTest.RecreateRootLayerWithCompositor > > BUG=337596 > > Committed: https://crrev.com/26d2ed6065c28b46c56a1266a6c7e28c9db55d45 > Cr-Commit-Position: refs/heads/master@{#319487} TBR=sadrul@chromium.org,danakj@chromium.org,bruthig@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=337596 Committed: https://crrev.com/81a24564ab2fdeda4703559c93c39c4dc4746dcd Cr-Commit-Position: refs/heads/master@{#319515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M ui/compositor/layer_owner.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/compositor/layer_owner_unittest.cc View 2 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Created Revert of Reset the root layer on the compositor when recreating a root layer.
5 years, 9 months ago (2015-03-06 22:14:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984103003/1
5 years, 9 months ago (2015-03-06 22:15:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 22:17:00 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 22:17:53 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81a24564ab2fdeda4703559c93c39c4dc4746dcd
Cr-Commit-Position: refs/heads/master@{#319515}

Powered by Google App Engine
This is Rietveld 408576698