Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 984073005: chrome: Simplify CPP files regex. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, M-A Ruel, tapted
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome: Simplify CPP files regex. This regex can be simplified down to a single-one. Similar to the way we already do elsewhere, like in //cc (https://chromium.googlesource.com/chromium/src/+/master/cc/PRESUBMIT.py) and ui/app_list (https://chromium.googlesource.com/chromium/src/+/master/ui/app_list/PRESUBMIT.py) BUG=None TEST=git cl presubmit -uv R=thestig@chromium.org Committed: https://crrev.com/6aed9aec2e85c226de6b024bd4d253dea7d95e86 Cr-Commit-Position: refs/heads/master@{#319573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
tfarina
5 years, 9 months ago (2015-03-07 00:29:56 UTC) #1
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-07 00:37:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984073005/1
5 years, 9 months ago (2015-03-07 21:13:59 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 9 months ago (2015-03-07 23:14:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984073005/1
5 years, 9 months ago (2015-03-07 23:50:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-08 03:54:15 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-08 03:55:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6aed9aec2e85c226de6b024bd4d253dea7d95e86
Cr-Commit-Position: refs/heads/master@{#319573}

Powered by Google App Engine
This is Rietveld 408576698