Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Side by Side Diff: chrome/PRESUBMIT.py

Issue 984073005: chrome: Simplify CPP files regex. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for changes affecting chrome/ 5 """Presubmit script for changes affecting chrome/
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
11 import re 11 import re
12 12
13 INCLUDE_CPP_FILES_ONLY = ( 13 INCLUDE_CPP_FILES_ONLY = (
14 r'.*\.cc$', r'.*\.h$' 14 r'.*\.(cc|h)$',
15 ) 15 )
16 16
17 EXCLUDE = ( 17 EXCLUDE = (
18 # Objective C confuses everything. 18 # Objective C confuses everything.
19 r'.*cocoa.*', 19 r'.*cocoa.*',
20 r'.*_mac\.(cc|h)$', 20 r'.*_mac\.(cc|h)$',
21 r'.*_mac_.*', 21 r'.*_mac_.*',
22 # All the messages files do weird multiple include trickery 22 # All the messages files do weird multiple include trickery
23 r'.*_messages.*\.h$', 23 r'.*_messages.*\.h$',
24 r'render_messages.h$', 24 r'render_messages.h$',
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 def CheckChangeOnUpload(input_api, output_api): 66 def CheckChangeOnUpload(input_api, output_api):
67 results = [] 67 results = []
68 results.extend(_CommonChecks(input_api, output_api)) 68 results.extend(_CommonChecks(input_api, output_api))
69 results.extend(_CheckChangeLintsClean(input_api, output_api)) 69 results.extend(_CheckChangeLintsClean(input_api, output_api))
70 return results 70 return results
71 71
72 def CheckChangeOnCommit(input_api, output_api): 72 def CheckChangeOnCommit(input_api, output_api):
73 results = [] 73 results = []
74 results.extend(_CommonChecks(input_api, output_api)) 74 results.extend(_CommonChecks(input_api, output_api))
75 return results 75 return results
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698