Issue 984023005: snapshot/mac: align members of 64-bit dyld_all_image_infos properly in 32-bit mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 984023005: snapshot/mac: align members of 64-bit dyld_all_image_infos properly in 32-bit mode (Closed)

Created:
5 years, 9 months ago by Mark Mentovai

Modified:
5 years, 9 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

snapshot/mac: align members of 64-bit dyld_all_image_infos properly in 32-bit mode. TEST=snapshot_test (specifically MachOImageAnnotationsReader.CrashDyld) R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/64b87325b9dee2dbad5cc9766f694156929f9efa

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	snapshot/mac/process_types/dyld_images.proctype	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	snapshot/mac/process_types/traits.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

I was trying to find a better way to attach alignas(8) or __attribute__((aligned(8))) to 64-bit ...

5 years, 9 months ago (2015-03-06 22:18:37 UTC) #2

Mark Mentovai

5 years, 9 months ago (2015-03-06 23:44:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
64b87325b9dee2dbad5cc9766f694156929f9efa (presubmit successful).