Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: snapshot/mac/process_types/dyld_images.proctype

Issue 984023005: snapshot/mac: align members of 64-bit dyld_all_image_infos properly in 32-bit mode (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | snapshot/mac/process_types/traits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/mac/process_types/dyld_images.proctype
diff --git a/snapshot/mac/process_types/dyld_images.proctype b/snapshot/mac/process_types/dyld_images.proctype
index de59a86c8ef78209c2c37a6d02306a185fadd6f9..3e45c99213e1132c63ceeb8377d7b36e930e4994 100644
--- a/snapshot/mac/process_types/dyld_images.proctype
+++ b/snapshot/mac/process_types/dyld_images.proctype
@@ -55,6 +55,13 @@ PROCESS_TYPE_STRUCT_BEGIN(dyld_all_image_infos)
// Version 2 (Mac OS X 10.6)
PROCESS_TYPE_STRUCT_MEMBER(bool, libSystemInitialized)
+ // This field does not appear in the system’s structure definition but is
+ // necessary to ensure that when building in 32-bit mode, the 64-bit version
+ // of the process_types structure matches the genuine 64-bit structure. This
+ // is required because the alignment constraints on 64-bit types are more
+ // stringent in 64-bit mode.
+ PROCESS_TYPE_STRUCT_MEMBER(Reserved64Only, alignment)
+
// const mach_header*
PROCESS_TYPE_STRUCT_MEMBER(Pointer, dyldImageLoadAddress)
« no previous file with comments | « no previous file | snapshot/mac/process_types/traits.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698