Chromium Code Reviews| Index: include/v8-profiler.h |
| diff --git a/include/v8-profiler.h b/include/v8-profiler.h |
| index 07f34e1385242e3bc95c7b9e7d1f935135a1b59a..8a7462f864fad61b7e68951f4cd1ee84e5b1236c 100644 |
| --- a/include/v8-profiler.h |
| +++ b/include/v8-profiler.h |
| @@ -313,12 +313,6 @@ class V8_EXPORT HeapSnapshot { |
| kJSON = 0 // See format description near 'Serialize' method. |
| }; |
| - /** Returns heap snapshot UID (assigned by the profiler.) */ |
| - unsigned GetUid() const; |
| - |
| - /** Returns heap snapshot title. */ |
| - Handle<String> GetTitle() const; |
| - |
| /** Returns the root node of the heap graph. */ |
| const HeapGraphNode* GetRoot() const; |
| @@ -367,7 +361,8 @@ class V8_EXPORT HeapSnapshot { |
| * Nodes reference strings, other nodes, and edges by their indexes |
| * in corresponding arrays. |
| */ |
| - void Serialize(OutputStream* stream, SerializationFormat format) const; |
| + void Serialize(OutputStream* stream, |
| + SerializationFormat format = kJSON) const; |
| }; |
| @@ -452,13 +447,18 @@ class V8_EXPORT HeapProfiler { |
| }; |
| /** |
| - * Takes a heap snapshot and returns it. Title may be an empty string. |
| + * Takes a heap snapshot and returns it. Title parameter is deprecated and |
| + * should be an empty string. |
| */ |
| const HeapSnapshot* TakeHeapSnapshot( |
|
alph
2015/03/10 10:23:26
V8_DEPRECATED
yurys
2015/03/10 10:23:57
I will need to fix Blink side first.
Yang
2015/03/10 10:38:11
Please add a TODO.
yurys
2015/03/10 12:08:39
Done.
|
| Handle<String> title, |
| ActivityControl* control = NULL, |
| ObjectNameResolver* global_object_name_resolver = NULL); |
| + const HeapSnapshot* TakeHeapSnapshot( |
| + ActivityControl* control = NULL, |
| + ObjectNameResolver* global_object_name_resolver = NULL); |
| + |
| /** |
| * Starts tracking of heap objects population statistics. After calling |
| * this method, all heap objects relocations done by the garbage collector |