Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1730)

Unified Diff: chrome/browser/ui/ash/system_tray_delegate_chromeos.cc

Issue 983823002: Use GUID instead of servicePath in network settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430115_internet_options_enable_extension_apis
Patch Set: Use guid instead of service_path for proxy prefs Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
diff --git a/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc b/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
index 001bb6dd3fef611c810f37fc17298506e26fd953..a5e5cc4bd3909d56caeb4d25ea29bdd84f38176a 100644
--- a/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
+++ b/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
@@ -174,13 +174,6 @@ void ShowSettingsSubPageForActiveUser(const std::string& sub_page) {
ProfileManager::GetActiveUserProfile(), sub_page);
}
-void ShowNetworkSettingsPage(const std::string& service_path) {
- std::string page = chrome::kInternetOptionsSubPage;
- page += "?servicePath=" + net::EscapeUrlEncodedData(service_path, true);
- content::RecordAction(base::UserMetricsAction("OpenInternetOptionsDialog"));
- ShowSettingsSubPageForActiveUser(page);
-}
-
void OnAcceptMultiprofilesIntro(bool no_show_again) {
PrefService* prefs = ProfileManager::GetActiveUserProfile()->GetPrefs();
prefs->SetBoolean(prefs::kMultiProfileNeverShowIntro, no_show_again);
@@ -453,15 +446,19 @@ void SystemTrayDelegateChromeOS::ShowSetTimeDialog() {
SetTimeDialog::ShowDialog(GetNativeWindow());
}
-void SystemTrayDelegateChromeOS::ShowNetworkSettings(
- const std::string& service_path) {
+void SystemTrayDelegateChromeOS::ShowNetworkSettingsForGuid(
+ const std::string& guid) {
bool userAddingRunning = ash::Shell::GetInstance()
->session_state_delegate()
->IsInSecondaryLoginScreen();
if (!LoginState::Get()->IsUserLoggedIn() || userAddingRunning)
return;
- ShowNetworkSettingsPage(service_path);
+ std::string page = chrome::kInternetOptionsSubPage;
+ if (!guid.empty())
+ page += "?guid=" + net::EscapeUrlEncodedData(guid, true);
+ content::RecordAction(base::UserMetricsAction("OpenInternetOptionsDialog"));
+ ShowSettingsSubPageForActiveUser(page);
}
void SystemTrayDelegateChromeOS::ShowBluetoothSettings() {
« no previous file with comments | « chrome/browser/ui/ash/system_tray_delegate_chromeos.h ('k') | chrome/browser/ui/browser_navigator_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698