chrome/browser/ui/browser_navigator_browsertest.cc - Issue 983823002: Use GUID instead of servicePath in network settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_navigator_browsertest.cc

Issue 983823002: Use GUID instead of servicePath in network settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430115_internet_options_enable_extension_apis

Patch Set: Use guid instead of service_path for proxy prefs Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/system_tray_delegate_chromeos.cc ('k') | chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_navigator_browsertest.cc

diff --git a/chrome/browser/ui/browser_navigator_browsertest.cc b/chrome/browser/ui/browser_navigator_browsertest.cc

index 12b537b92853ed80ad0aa600d9b84d43618bafd9..7ab288bd85e8609f55ec464ead2f198537a4feff 100644

--- a/chrome/browser/ui/browser_navigator_browsertest.cc

+++ b/chrome/browser/ui/browser_navigator_browsertest.cc

@@ -955,7 +955,7 @@ IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest,

// Navigate to a different settings path.

GURL singleton_url_target(

"chrome://settings/internet?"

- "servicePath=/profile/ethernet_00aa00aa00aa&networkType=1");

+ "guid=ethernet_00aa00aa00aa&networkType=1");

chrome::NavigateParams params(MakeNavigateParams());

params.disposition = SINGLETON_TAB;

params.url = singleton_url_target;