chrome/browser/chromeos/status/data_promo_notification.cc - Issue 983823002: Use GUID instead of servicePath in network settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/status/data_promo_notification.cc

Issue 983823002: Use GUID instead of servicePath in network settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430115_internet_options_enable_extension_apis

Patch Set: Use guid instead of service_path for proxy prefs Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/status/data_promo_notification.cc

diff --git a/chrome/browser/chromeos/status/data_promo_notification.cc b/chrome/browser/chromeos/status/data_promo_notification.cc

index 0cf7b9cfaa21517d8720174fcf7db461491b2219..821e95a6cfd00fbc83c03066ad036853057e7571 100644

--- a/chrome/browser/chromeos/status/data_promo_notification.cc

+++ b/chrome/browser/chromeos/status/data_promo_notification.cc

@@ -124,7 +124,7 @@ const chromeos::MobileConfig::CarrierDeal* GetCarrierDeal(

void NotificationClicked(const std::string& service_path,

const std::string& info_url) {

if (info_url.empty())

- ui::NetworkConnect::Get()->ShowNetworkSettings(service_path);

+ ui::NetworkConnect::Get()->ShowNetworkSettingsForPath(service_path);

chrome::ScopedTabbedBrowserDisplayer displayer(

ProfileManager::GetPrimaryUserProfile(),

« no previous file with comments | « chrome/browser/chromeos/offline/offline_load_page.cc ('k') | chrome/browser/chromeos/ui_proxy_config_service.h » ('j') | no next file with comments »