chrome/browser/chromeos/offline/offline_load_page.cc - Issue 983823002: Use GUID instead of servicePath in network settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/offline/offline_load_page.cc

Issue 983823002: Use GUID instead of servicePath in network settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430115_internet_options_enable_extension_apis

Patch Set: Use guid instead of service_path for proxy prefs Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc ('k') | chrome/browser/chromeos/status/data_promo_notification.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/offline/offline_load_page.cc

diff --git a/chrome/browser/chromeos/offline/offline_load_page.cc b/chrome/browser/chromeos/offline/offline_load_page.cc

index f2db48bfb690867a633d95c8cd38de0c8b3b1f75..55f590eebd02d9d326017eec6549b75be7e61c3f 100644

--- a/chrome/browser/chromeos/offline/offline_load_page.cc

+++ b/chrome/browser/chromeos/offline/offline_load_page.cc

@@ -132,7 +132,9 @@ void OfflineLoadPage::CommandReceived(const std::string& cmd) {

}

// TODO(oshima): record action for metrics.

if (command == "open_network_settings") {

- ash::Shell::GetInstance()->system_tray_delegate()->ShowNetworkSettings("");

+ ash::Shell::GetInstance()

+ ->system_tray_delegate()

+ ->ShowNetworkSettingsForGuid("");

} else if (command == "open_connectivity_diagnostics") {

Profile* profile = Profile::FromBrowserContext(

web_contents_->GetBrowserContext());