Issue 983793004: Prevent already scheduled-for-render fn components which become removed from rendering

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 983793004: Prevent already scheduled-for-render fn components which become removed from rendering (Closed)

Created:
5 years, 9 months ago by rafaelw

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Prevent already scheduled-for-render fn components which become removed from rendering This can occur, for instance, if a child component runs before a parent component within a single animation frame, and the child does setState() while the parent removes it. The child will already have been entered into the rendering queue. TBR=eseidel BUG= Committed: https://chromium.googlesource.com/external/mojo/+/31b17b1c47ccd8fd078a98d9109aaa20ec1a314b

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	sky/framework/fn.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rafaelw

Committed patchset #1 (id:1) manually as 31b17b1c47ccd8fd078a98d9109aaa20ec1a314b (presubmit successful).

5 years, 9 months ago (2015-03-06 22:16:24 UTC) #2

eseidel

5 years, 9 months ago (2015-03-06 22:19:15 UTC) #3

Message was sent while issue was closed.

lgtm.  Eventually we'll want to start unittesting, but that doesn't have to be
today.

Expand Messages | Collapse Messages