Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1617)

Unified Diff: sky/framework/fn.dart

Issue 983793004: Prevent already scheduled-for-render fn components which become removed from rendering (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/fn.dart
diff --git a/sky/framework/fn.dart b/sky/framework/fn.dart
index dbf193ab04bfd2e9cf116267bcc7430a0102d864..c921a4c2f48fbfb51bada7d6b85d545cf2d76346 100644
--- a/sky/framework/fn.dart
+++ b/sky/framework/fn.dart
@@ -636,13 +636,17 @@ abstract class Component extends Node {
}
void _renderIfDirty() {
+ if (_removed)
+ return;
+
assert(_rendered != null);
- assert(!_removed);
var rendered = _rendered;
while (rendered is Component) {
rendered = rendered._rendered;
}
+
+ assert(rendered._root != null);
sky.Node root = rendered._root;
_renderInternal(root.parentNode, root.nextSibling);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698