Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 983793003: Replace extensions::ScopedPersistent with v8::UniquePersistent. (Closed)

Created:
5 years, 9 months ago by not at google - send to devlin
Modified:
5 years, 9 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace extensions::ScopedPersistent with v8::UniquePersistent. R=jochen@chromium.org Committed: https://crrev.com/078a21994451a696f3cad1d26872adf590dfc651 Cr-Commit-Position: refs/heads/master@{#319688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -161 lines) Patch
M chrome/renderer/extensions/cast_streaming_native_handler.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/cast_streaming_native_handler.cc View 7 chunks +20 lines, -16 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/extensions.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/activity_log_converter_strategy_unittest.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M extensions/renderer/app_window_custom_bindings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/guest_view/extensions_guest_view_container.h View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/renderer/guest_view/extensions_guest_view_container.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h View 2 chunks +2 lines, -3 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/messaging_bindings.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M extensions/renderer/module_system_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/object_backed_native_handler.h View 2 chunks +1 line, -2 lines 0 comments Download
M extensions/renderer/object_backed_native_handler.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M extensions/renderer/render_view_observer_natives.cc View 2 chunks +6 lines, -3 lines 0 comments Download
D extensions/renderer/scoped_persistent.h View 1 chunk +0 lines, -85 lines 0 comments Download
M extensions/renderer/script_context.h View 3 chunks +2 lines, -3 lines 0 comments Download
M extensions/renderer/script_context.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
not at google - send to devlin
Is there an easier way to write all of this than v8::Local<v8::Whatever>::New(isolate, handle)? It's pretty ...
5 years, 9 months ago (2015-03-06 21:17:41 UTC) #1
jochen (gone - plz use gerrit)
nope, sorry lgtm
5 years, 9 months ago (2015-03-09 15:41:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983793003/1
5 years, 9 months ago (2015-03-09 15:51:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 18:20:06 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 18:21:01 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/078a21994451a696f3cad1d26872adf590dfc651
Cr-Commit-Position: refs/heads/master@{#319688}

Powered by Google App Engine
This is Rietveld 408576698