Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: extensions/renderer/object_backed_native_handler.cc

Issue 983793003: Replace extensions::ScopedPersistent with v8::UniquePersistent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/object_backed_native_handler.h" 5 #include "extensions/renderer/object_backed_native_handler.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/memory/linked_ptr.h" 8 #include "base/memory/linked_ptr.h"
9 #include "extensions/renderer/console.h" 9 #include "extensions/renderer/console.h"
10 #include "extensions/renderer/module_system.h" 10 #include "extensions/renderer/module_system.h"
11 #include "extensions/renderer/script_context.h" 11 #include "extensions/renderer/script_context.h"
12 #include "v8/include/v8.h" 12 #include "v8/include/v8.h"
13 13
14 namespace extensions { 14 namespace extensions {
15 15
16 namespace { 16 namespace {
17 // Key for the base::Bound routed function. 17 // Key for the base::Bound routed function.
18 const char* kHandlerFunction = "handler_function"; 18 const char* kHandlerFunction = "handler_function";
19 } // namespace 19 } // namespace
20 20
21 ObjectBackedNativeHandler::ObjectBackedNativeHandler(ScriptContext* context) 21 ObjectBackedNativeHandler::ObjectBackedNativeHandler(ScriptContext* context)
22 : router_data_(context->v8_context()->GetIsolate()), 22 : router_data_(context->isolate()),
23 context_(context), 23 context_(context),
24 object_template_( 24 object_template_(context->isolate(),
25 v8::ObjectTemplate::New(context->v8_context()->GetIsolate())) {} 25 v8::ObjectTemplate::New(context->isolate())) {
26 }
26 27
27 ObjectBackedNativeHandler::~ObjectBackedNativeHandler() { Invalidate(); } 28 ObjectBackedNativeHandler::~ObjectBackedNativeHandler() { Invalidate(); }
28 29
29 v8::Handle<v8::Object> ObjectBackedNativeHandler::NewInstance() { 30 v8::Handle<v8::Object> ObjectBackedNativeHandler::NewInstance() {
30 return object_template_.NewHandle(v8::Isolate::GetCurrent())->NewInstance(); 31 return v8::Local<v8::ObjectTemplate>::New(GetIsolate(), object_template_)
32 ->NewInstance();
31 } 33 }
32 34
33 // static 35 // static
34 void ObjectBackedNativeHandler::Router( 36 void ObjectBackedNativeHandler::Router(
35 const v8::FunctionCallbackInfo<v8::Value>& args) { 37 const v8::FunctionCallbackInfo<v8::Value>& args) {
36 v8::HandleScope handle_scope(args.GetIsolate()); 38 v8::HandleScope handle_scope(args.GetIsolate());
37 v8::Handle<v8::Object> data = args.Data().As<v8::Object>(); 39 v8::Handle<v8::Object> data = args.Data().As<v8::Object>();
38 40
39 v8::Handle<v8::Value> handler_function_value = 41 v8::Handle<v8::Value> handler_function_value =
40 data->Get(v8::String::NewFromUtf8(args.GetIsolate(), kHandlerFunction)); 42 data->Get(v8::String::NewFromUtf8(args.GetIsolate(), kHandlerFunction));
(...skipping 15 matching lines...) Expand all
56 v8::Isolate* isolate = v8::Isolate::GetCurrent(); 58 v8::Isolate* isolate = v8::Isolate::GetCurrent();
57 v8::HandleScope handle_scope(isolate); 59 v8::HandleScope handle_scope(isolate);
58 v8::Context::Scope context_scope(context_->v8_context()); 60 v8::Context::Scope context_scope(context_->v8_context());
59 61
60 v8::Local<v8::Object> data = v8::Object::New(isolate); 62 v8::Local<v8::Object> data = v8::Object::New(isolate);
61 data->Set( 63 data->Set(
62 v8::String::NewFromUtf8(isolate, kHandlerFunction), 64 v8::String::NewFromUtf8(isolate, kHandlerFunction),
63 v8::External::New(isolate, new HandlerFunction(handler_function))); 65 v8::External::New(isolate, new HandlerFunction(handler_function)));
64 v8::Handle<v8::FunctionTemplate> function_template = 66 v8::Handle<v8::FunctionTemplate> function_template =
65 v8::FunctionTemplate::New(isolate, Router, data); 67 v8::FunctionTemplate::New(isolate, Router, data);
66 object_template_.NewHandle(isolate) 68 v8::Local<v8::ObjectTemplate>::New(isolate, object_template_)
67 ->Set(isolate, name.c_str(), function_template); 69 ->Set(isolate, name.c_str(), function_template);
68 router_data_.Append(data); 70 router_data_.Append(data);
69 } 71 }
70 72
71 v8::Isolate* ObjectBackedNativeHandler::GetIsolate() const { 73 v8::Isolate* ObjectBackedNativeHandler::GetIsolate() const {
72 return context_->isolate(); 74 return context_->isolate();
73 } 75 }
74 76
75 void ObjectBackedNativeHandler::Invalidate() { 77 void ObjectBackedNativeHandler::Invalidate() {
76 if (!is_valid()) 78 if (!is_valid())
77 return; 79 return;
78 v8::Isolate* isolate = v8::Isolate::GetCurrent(); 80 v8::Isolate* isolate = v8::Isolate::GetCurrent();
79 v8::HandleScope handle_scope(isolate); 81 v8::HandleScope handle_scope(isolate);
80 v8::Context::Scope context_scope(context_->v8_context()); 82 v8::Context::Scope context_scope(context_->v8_context());
81 83
82 for (size_t i = 0; i < router_data_.Size(); i++) { 84 for (size_t i = 0; i < router_data_.Size(); i++) {
83 v8::Handle<v8::Object> data = router_data_.Get(i); 85 v8::Handle<v8::Object> data = router_data_.Get(i);
84 v8::Handle<v8::Value> handler_function_value = 86 v8::Handle<v8::Value> handler_function_value =
85 data->Get(v8::String::NewFromUtf8(isolate, kHandlerFunction)); 87 data->Get(v8::String::NewFromUtf8(isolate, kHandlerFunction));
86 CHECK(!handler_function_value.IsEmpty()); 88 CHECK(!handler_function_value.IsEmpty());
87 delete static_cast<HandlerFunction*>( 89 delete static_cast<HandlerFunction*>(
88 handler_function_value.As<v8::External>()->Value()); 90 handler_function_value.As<v8::External>()->Value());
89 data->Delete(v8::String::NewFromUtf8(isolate, kHandlerFunction)); 91 data->Delete(v8::String::NewFromUtf8(isolate, kHandlerFunction));
90 } 92 }
91 router_data_.Clear(); 93 router_data_.Clear();
92 object_template_.reset(); 94 object_template_.Reset();
93 context_ = NULL; 95 context_ = NULL;
94 NativeHandler::Invalidate(); 96 NativeHandler::Invalidate();
95 } 97 }
96 98
97 } // namespace extensions 99 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/renderer/object_backed_native_handler.h ('k') | extensions/renderer/render_view_observer_natives.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698