chrome/browser/extensions/extension_webstore_private_apitest.cc - Issue 9837054: Improve WebstoreInstaller error handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_webstore_private_apitest.cc

Issue 9837054: Improve WebstoreInstaller error handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_webstore_private_apitest.cc

diff --git a/chrome/browser/extensions/extension_webstore_private_apitest.cc b/chrome/browser/extensions/extension_webstore_private_apitest.cc

index 2fb2b4572ee4a95d213eb9d94ab588b72487c3a3..648943518ad01e3ec7c802f8dd81079a2e346659 100644

--- a/chrome/browser/extensions/extension_webstore_private_apitest.cc

+++ b/chrome/browser/extensions/extension_webstore_private_apitest.cc

@@ -351,7 +351,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebstorePrivateBundleTest,

PackInvalidCRX("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");

PackCRX("bmfoocgfinpmkmlbjhcbofejhkhlbchk", "extension1.json");

- PackCRX("pkapffpjmiilhlhbibjhamlmdhfneidj", "extension2.json");

PackCRX("begfmnajjkbjdgmffnjaojchoncnmngg", "app1.json");

ASSERT_TRUE(RunPageTest(GetTestServerURL(

@@ -359,8 +358,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebstorePrivateBundleTest,

ASSERT_TRUE(service()->GetExtensionById(

"begfmnajjkbjdgmffnjaojchoncnmngg", false));

- ASSERT_TRUE(service()->GetExtensionById(

- "pkapffpjmiilhlhbibjhamlmdhfneidj", false));

+ ASSERT_FALSE(service()->GetExtensionById(

+ "pkapffpjmiilhlhbibjhamlmdhfneidj", true));

ASSERT_FALSE(service()->GetExtensionById(

"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", true));

ASSERT_FALSE(service()->GetExtensionById(

« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_installer.h » ('j') | no next file with comments »