Improve WebstoreInstaller error handling.

chrome/browser/extensions/extension_webstore_private_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/stringprintf.h"
 #include "chrome/browser/extensions/bundle_installer.h"
@@ skipping 333 matching lines @@
 }
 
 // Tests partially installing a bundle (2 succeed, 1 fails due to an invalid
 // CRX, and 1 fails due to the manifests not matching).
 IN_PROC_BROWSER_TEST_F(ExtensionWebstorePrivateBundleTest,
                        InstallBundleInvalid) {
   extensions::BundleInstaller::SetAutoApproveForTesting(true);
 
   PackInvalidCRX("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
   PackCRX("bmfoocgfinpmkmlbjhcbofejhkhlbchk", "extension1.json");
-  PackCRX("pkapffpjmiilhlhbibjhamlmdhfneidj", "extension2.json");
   PackCRX("begfmnajjkbjdgmffnjaojchoncnmngg", "app1.json");
 
   ASSERT_TRUE(RunPageTest(GetTestServerURL(
       "install_bundle_invalid.html").spec()));
 
   ASSERT_TRUE(service()->GetExtensionById(
       "begfmnajjkbjdgmffnjaojchoncnmngg", false));
-  ASSERT_TRUE(service()->GetExtensionById(
-      "pkapffpjmiilhlhbibjhamlmdhfneidj", false));
+  ASSERT_FALSE(service()->GetExtensionById(
+      "pkapffpjmiilhlhbibjhamlmdhfneidj", true));
   ASSERT_FALSE(service()->GetExtensionById(
       "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", true));
   ASSERT_FALSE(service()->GetExtensionById(
       "bmfoocgfinpmkmlbjhcbofejhkhlbchk", true));
 }
 
 // Tests getWebGLStatus function when WebGL is allowed.
 IN_PROC_BROWSER_TEST_F(ExtensionWebstoreGetWebGLStatusTest, Allowed) {
   bool webgl_allowed = true;
   RunTest(webgl_allowed);
@@ skipping 20 matching lines @@
   ASSERT_TRUE(blacklist->LoadGpuBlacklist(
       json_blacklist, GpuBlacklist::kAllOs));
   blacklist->UpdateGpuDataManager();
   GpuFeatureType type =
       content::GpuDataManager::GetInstance()->GetGpuFeatureType();
   EXPECT_EQ(type, content::GPU_FEATURE_TYPE_WEBGL);
 
   bool webgl_allowed = false;
   RunTest(webgl_allowed);
 }