Issue 983653002: Revert of rename UniquePersistent to Global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 983653002: Revert of rename UniquePersistent to Global (Closed)

Created:
5 years, 9 months ago by Michael Achenbach

Modified:
5 years, 9 months ago

Reviewers:
Sven Panne, dcarney

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of rename UniquePersistent to Global (patchset #2 id:20001 of https://codereview.chromium.org/980173003/) Reason for revert: breaks arm compile Original issue's description: > rename UniquePersistent to Global > > BUG= > > Committed: https://crrev.com/3f5ae16c62b031ad572f750d81ffc71c5d6d1f9b > Cr-Commit-Position: refs/heads/master@{#27011} TBR=svenpanne@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/8465f397927bb10ea32c958cf4f82a8e15c02e24 Cr-Commit-Position: refs/heads/master@{#27012}

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -44 lines)			Patch
	M	include/v8.h	View		4 chunks	+23 lines, -29 lines	0 comments	Download
	M	test/cctest/test-api.cc	View		10 chunks	+17 lines, -15 lines	0 comments	Download

Total messages: 4 (0 generated)

Michael Achenbach

Created Revert of rename UniquePersistent to Global

5 years, 9 months ago (2015-03-05 12:09:14 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983653002/1

5 years, 9 months ago (2015-03-05 12:10:12 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-05 12:10:49 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8465f397927bb10ea32c958cf4f82a8e15c02e24
Cr-Commit-Position: refs/heads/master@{#27012}