Move mac_bundle_id and other variables from chrome.gyp to build/chrome_settings.gypi.

Move mac_bundle_id and other variables from chrome.gyp to build/chrome_settings.gypi.

These variables could be used from any gypi file included from chrome.gyp.
However, policy_templates.gypi is moving into components/policy.gypi, which
is included from components/components.gyp instead.

Moving the variables to build/chrome_settings.gypi enables their use from other gyp files.

BUG=271392
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240367

[Joao da Silva, 2013-12-11 22:47:23]

Hi guys, PTAL. The CL description sums it up, does this make sense to you?

Thanks!

[Mark Mentovai, 2013-12-11 23:04:05]

Which of these variables does policy need?

[Joao da Silva, 2013-12-11 23:12:54]

On 2013/12/11 23:04:05, Mark Mentovai wrote:
> Which of these variables does policy need?

See target 'chrome_manifest_bundle' at chrome/app/policy/policy_templates.gypi.
It's used to build a plist bundled in the Chrome.app bundle that describes the
supported policies, so that Chrome.app can be drag'n'dropped into the Workgroup
Manager (http://support.apple.com/kb/DL1698).

That plist can be localized, and needs 'apply_locales_cmd' to iterate over the
locale files generated.

It also needs the 'mac_bundle_id' to generate the correct filename for the
plist; it's also used inside that file.

'mac_creator' is not needed by the policy target but I just moved it all
together. I only found remoting/remoting.gyp also setting it; IIUC it gets
overridden there with this change.

[Mark Mentovai, 2013-12-11 23:17:40]

I would have a slight preference to put this in its own gypi file that
chrome.gyp and policy.gyp could include, instead of dumping it in the wasteland
of common.gypi. build/chrome_settings.gypi?

If you hate that, I will LG this as-is.

[Joao da Silva, 2013-12-11 23:21:57]

On 2013/12/11 23:17:40, Mark Mentovai wrote:
> I would have a slight preference to put this in its own gypi file that
> chrome.gyp and policy.gyp could include, instead of dumping it in the
wasteland
> of common.gypi. build/chrome_settings.gypi?
> 
> If you hate that, I will LG this as-is.

I guess that's fine; this doesn't depend on other policy targets so it can be
split into its own gypi and get included from chrome.gyp.

Thanks for having a look, I'll close this.

[Mark Mentovai, 2013-12-11 23:24:22]

Oh. That’s not really what I meant.

I meant that policy.gyp and chrome.gyp could both include some_new.gypi to get
these Chromey variables set the same way in both of them. It would work exactly
the same as it currently works, where common.gypi is included into all .gyp
files, except the include would be explicit.

[Joao da Silva, 2013-12-12 07:49:38]

Thanks for clarifying, I prefer this arrangement too. PTAL

[Mark Mentovai, 2013-12-12 13:54:45]

LGTM

https://codereview.chromium.org/98363007/diff/10001/build/chrome_settings.gypi
File build/chrome_settings.gypi (right):

https://codereview.chromium.org/98363007/diff/10001/build/chrome_settings.gyp...
build/chrome_settings.gypi:28: ]  # conditions
We normally would stick a trailing comma at the end of this line and the next
line, to make it less difficult for people who later come and add sections to
the file expecting the commas to be there without actually looking for them.

(But you can’t put one on the last line.)

[Joao da Silva, 2013-12-12 14:31:17]

Thanks for the help!

https://codereview.chromium.org/98363007/diff/10001/build/chrome_settings.gypi
File build/chrome_settings.gypi (right):

https://codereview.chromium.org/98363007/diff/10001/build/chrome_settings.gyp...
build/chrome_settings.gypi:28: ]  # conditions
On 2013/12/12 13:54:45, Mark Mentovai wrote:
> We normally would stick a trailing comma at the end of this line and the next
> line, to make it less difficult for people who later come and add sections to
> the file expecting the commas to be there without actually looking for them.
> 
> (But you can’t put one on the last line.)

Done.

[commit-bot: I haz the power, 2013-12-12 14:32:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/98363007/30001

[commit-bot: I haz the power, 2013-12-12 14:51:40]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Joao da Silva, 2013-12-12 14:53:54]

+Jochen to review chrome.gyp. PTAL, thanks!

[jochen (gone - plz use gerrit), 2013-12-12 15:15:15]

lgtm

[commit-bot: I haz the power, 2013-12-12 15:20:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/98363007/30001

[commit-bot: I haz the power, 2013-12-12 18:34:39]

Change committed as 240367