Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8381)

Unified Diff: chrome/chrome.gyp

Issue 98363007: Move mac_bundle_id and other variables from chrome.gyp to build/chrome_settings.gypi. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: trailing commas Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/chrome_settings.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.gyp
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp
index 0cc23652e98fc57ba60e641b8d94171aca83cdde..deb868a51bd9c7e99b685355e8ebc93ac7861ba1 100644
--- a/chrome/chrome.gyp
+++ b/chrome/chrome.gyp
@@ -23,8 +23,6 @@
'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/chrome',
'protoc_out_dir': '<(SHARED_INTERMEDIATE_DIR)/protoc_out',
'repack_locales_cmd': ['python', 'tools/build/repack_locales.py'],
- # TODO: remove this helper when we have loops in GYP
- 'apply_locales_cmd': ['python', '<(DEPTH)/build/apply_locales.py'],
'conditions': [
['OS!="ios"', {
'chromium_browser_dependencies': [
@@ -81,19 +79,6 @@
'tweak_info_plist_path': '../build/mac/tweak_info_plist.py',
'platform_locale_settings_grd':
'app/resources/locale_settings_mac.grd',
- 'conditions': [
- ['branding=="Chrome"', {
- 'mac_bundle_id': 'com.google.Chrome',
- 'mac_creator': 'rimZ',
- # The policy .grd file also needs the bundle id.
- 'grit_defines': ['-D', 'mac_bundle_id=com.google.Chrome'],
- }, { # else: branding!="Chrome"
- 'mac_bundle_id': 'org.chromium.Chromium',
- 'mac_creator': 'Cr24',
- # The policy .grd file also needs the bundle id.
- 'grit_defines': ['-D', 'mac_bundle_id=org.chromium.Chromium'],
- }], # branding
- ], # conditions
}], # OS=="mac"
], # conditions
}, # variables
@@ -104,6 +89,7 @@
# on 64-bit Windows only. Targets that end with nacl_win64 should be used
# by Native Client only.
# NOTE: Most new includes should go in the OS!="ios" condition below.
+ '../build/chrome_settings.gypi',
'../build/win_precompile.gypi',
'chrome_browser.gypi',
'chrome_browser_ui.gypi',
« no previous file with comments | « build/chrome_settings.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698