Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 983223002: Hotlist Slow: Adopt ChromeOS Session restore tab loading timeouts. (Closed)

Created:
5 years, 9 months ago by tommycli
Modified:
5 years, 9 months ago
CC:
chromium-reviews, marja+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hotlist Slow: Adopt ChromeOS Session restore tab loading timeouts. 1. Changes desktop tab load time from 100ms to 1500ms. 2. Doesn't preload tabs if network is down. In my manual testing, the ChromeOS 1500ms timeout does not feel slow. It actually feels "just right". BUG=463567 Committed: https://crrev.com/7eb9be569e9e4584624d1617a84d3cc57ea6d8ba Cr-Commit-Position: refs/heads/master@{#319547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -78 lines) Patch
M chrome/browser/sessions/tab_loader_delegate.cc View 1 chunk +41 lines, -9 lines 0 comments Download
D chrome/browser/sessions/tab_loader_delegate_chromeos.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
tommycli
skuhne, thestig: PTAL for bug reporter and OWNER, respectively. This patch is just a straight ...
5 years, 9 months ago (2015-03-06 22:46:07 UTC) #2
Mr4D (OOO till 08-26)
lgtm
5 years, 9 months ago (2015-03-06 22:59:16 UTC) #3
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-06 23:06:22 UTC) #4
tommycli
skuhne, thestig: thanks for ridiculously fast reviews
5 years, 9 months ago (2015-03-06 23:16:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983223002/1
5 years, 9 months ago (2015-03-06 23:18:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 9 months ago (2015-03-07 01:43:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983223002/1
5 years, 9 months ago (2015-03-07 03:05:10 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-07 03:06:22 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7eb9be569e9e4584624d1617a84d3cc57ea6d8ba Cr-Commit-Position: refs/heads/master@{#319547}
5 years, 9 months ago (2015-03-07 03:06:58 UTC) #13
chrisha
Drive by: Is it worth wrapping this in a Finch experiment, and actually exploring for ...
5 years, 9 months ago (2015-03-10 16:41:53 UTC) #15
tommycli
5 years, 9 months ago (2015-03-18 18:45:22 UTC) #16
Message was sent while issue was closed.
On 2015/03/10 16:41:53, chrisha wrote:
> Drive by:
> 
> Is it worth wrapping this in a Finch experiment, and actually exploring for
the
> best value? Do we have key metrics that we can track to quantify the impact?
If
> not, can we add them?

Hi chrisha:

On this thread we discuss the metrics showing reduced CPU usage:
https://groups.google.com/a/google.com/d/msg/chrome-fast/0Ly9H-un8WY/5ok8Ctn5...

Powered by Google App Engine
This is Rietveld 408576698