Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: chrome/browser/sessions/tab_loader_delegate_chromeos.cc

Issue 983223002: Hotlist Slow: Adopt ChromeOS Session restore tab loading timeouts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sessions/tab_loader_delegate.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/tab_loader_delegate_chromeos.cc
diff --git a/chrome/browser/sessions/tab_loader_delegate_chromeos.cc b/chrome/browser/sessions/tab_loader_delegate_chromeos.cc
deleted file mode 100644
index 640495ed68077d5f8379997dd0b7d310c539196f..0000000000000000000000000000000000000000
--- a/chrome/browser/sessions/tab_loader_delegate_chromeos.cc
+++ /dev/null
@@ -1,68 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/sessions/tab_loader_delegate.h"
-
-#include "net/base/network_change_notifier.h"
-
-namespace {
-
-// The timeout time after which the next tab gets loaded if the previous tab did
-// not finish loading yet. The used value is half of the median value of all
-// ChromeOS devices loading the 25 most common web pages. Half is chosen since
-// the loading time is a mix of server response and data bandwidth.
-static const int kInitialDelayTimerMS = 1500;
-
-class TabLoaderDelegateImpl
- : public TabLoaderDelegate,
- public net::NetworkChangeNotifier::ConnectionTypeObserver {
- public:
- explicit TabLoaderDelegateImpl(TabLoaderCallback* callback);
- ~TabLoaderDelegateImpl() override;
-
- // TabLoaderDelegate:
- base::TimeDelta GetTimeoutBeforeLoadingNextTab() const override {
- return base::TimeDelta::FromMilliseconds(kInitialDelayTimerMS);
- }
-
- // net::NetworkChangeNotifier::ConnectionTypeObserver:
- void OnConnectionTypeChanged(
- net::NetworkChangeNotifier::ConnectionType type) override;
-
- private:
- // The function to call when the connection type changes.
- TabLoaderCallback* callback_;
-
- DISALLOW_COPY_AND_ASSIGN(TabLoaderDelegateImpl);
-};
-
-TabLoaderDelegateImpl::TabLoaderDelegateImpl(TabLoaderCallback* callback)
- : callback_(callback) {
- net::NetworkChangeNotifier::AddConnectionTypeObserver(this);
- if (net::NetworkChangeNotifier::IsOffline()) {
- // When we are off-line we do not allow loading of tabs, since each of
- // these tabs would start loading simultaneously when going online.
- // TODO(skuhne): Once we get a higher level resource control logic which
- // distributes network access, we can remove this.
- callback->SetTabLoadingEnabled(false);
- }
-}
-
-TabLoaderDelegateImpl::~TabLoaderDelegateImpl() {
- net::NetworkChangeNotifier::RemoveConnectionTypeObserver(this);
-}
-
-void TabLoaderDelegateImpl::OnConnectionTypeChanged(
- net::NetworkChangeNotifier::ConnectionType type) {
- callback_->SetTabLoadingEnabled(
- type != net::NetworkChangeNotifier::CONNECTION_NONE);
-}
-} // namespace
-
-// static
-scoped_ptr<TabLoaderDelegate> TabLoaderDelegate::Create(
- TabLoaderCallback* callback) {
- return scoped_ptr<TabLoaderDelegate>(
- new TabLoaderDelegateImpl(callback));
-}
« no previous file with comments | « chrome/browser/sessions/tab_loader_delegate.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698