chrome/browser/service_process/service_process_control_mac.mm - Issue 982883003: Use fixed socket name instead of SecureSocketWithKey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/service_process/service_process_control_mac.mm

Issue 982883003: Use fixed socket name instead of SecureSocketWithKey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/service_process/service_process_control_mac.mm

diff --git a/chrome/browser/service_process/service_process_control_mac.mm b/chrome/browser/service_process/service_process_control_mac.mm

index e7ae3b475a39a141c2fc8cd1a803fe8af7b62003..1ad9e365aafcd0bb9a60bae482aad024356119a3 100644

--- a/chrome/browser/service_process/service_process_control_mac.mm

+++ b/chrome/browser/service_process/service_process_control_mac.mm

@@ -6,6 +6,7 @@

#include "base/bind.h"

#include "base/command_line.h"

+#include "base/mac/foundation_util.h" // operator<< for CFErrorRef

Robert Sesek 2015/03/05 22:34:02 These comments quickly become stale and aren't ter

Vitaly Buka (NO REVIEWS) 2015/03/05 23:22:13 sure. my concern is that it compiles with or witho

#include "base/mac/scoped_cftyperef.h"

#include "chrome/common/service_process_util_posix.h"

#include "content/public/browser/browser_thread.h"

« no previous file with comments | « no previous file | chrome/common/service_process_util.h » ('j') | chrome/common/service_process_util_mac.mm » ('J')