Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: chrome/browser/service_process/service_process_control_mac.mm

Issue 982883003: Use fixed socket name instead of SecureSocketWithKey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/service_process/service_process_control.h" 5 #include "chrome/browser/service_process/service_process_control.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/mac/foundation_util.h" // operator<< for CFErrorRef
Robert Sesek 2015/03/05 22:34:02 These comments quickly become stale and aren't ter
Vitaly Buka (NO REVIEWS) 2015/03/05 23:22:13 sure. my concern is that it compiles with or witho
9 #include "base/mac/scoped_cftyperef.h" 10 #include "base/mac/scoped_cftyperef.h"
10 #include "chrome/common/service_process_util_posix.h" 11 #include "chrome/common/service_process_util_posix.h"
11 #include "content/public/browser/browser_thread.h" 12 #include "content/public/browser/browser_thread.h"
12 #include "third_party/google_toolbox_for_mac/src/Foundation/GTMServiceManagement .h" 13 #include "third_party/google_toolbox_for_mac/src/Foundation/GTMServiceManagement .h"
13 14
14 using content::BrowserThread; 15 using content::BrowserThread;
15 16
16 void ServiceProcessControl::Launcher::DoRun() { 17 void ServiceProcessControl::Launcher::DoRun() {
17 base::ScopedCFTypeRef<CFDictionaryRef> launchd_plist( 18 base::ScopedCFTypeRef<CFDictionaryRef> launchd_plist(
18 CreateServiceProcessLaunchdPlist(cmd_line_.get(), false)); 19 CreateServiceProcessLaunchdPlist(cmd_line_.get(), false));
19 CFErrorRef error = NULL; 20 CFErrorRef error = NULL;
20 if (!GTMSMJobSubmit(launchd_plist, &error)) { 21 if (!GTMSMJobSubmit(launchd_plist, &error)) {
21 LOG(ERROR) << error; 22 LOG(ERROR) << error;
22 CFRelease(error); 23 CFRelease(error);
23 } else { 24 } else {
24 launched_ = true; 25 launched_ = true;
25 } 26 }
26 BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, 27 BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
27 base::Bind(&Launcher::Notify, this)); 28 base::Bind(&Launcher::Notify, this));
28 } 29 }
OLDNEW
« no previous file with comments | « no previous file | chrome/common/service_process_util.h » ('j') | chrome/common/service_process_util_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698