sync/internal_api/public/attachments/attachment_downloader_impl.h - Issue 982883002: [Sync] Add size and crc32c to AttachmentId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/attachments/attachment_downloader_impl.h

Issue 982883002: [Sync] Add size and crc32c to AttachmentId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix argument evaluation order bug. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/public/attachments/attachment_downloader_impl.h

diff --git a/sync/internal_api/public/attachments/attachment_downloader_impl.h b/sync/internal_api/public/attachments/attachment_downloader_impl.h

index 4e68f272e8db9c33a6dd0e428fabaa4638647989..83bb77eeb751f198d5480257e000ad1458f9d014 100644

--- a/sync/internal_api/public/attachments/attachment_downloader_impl.h

+++ b/sync/internal_api/public/attachments/attachment_downloader_impl.h

@@ -88,8 +88,7 @@ class AttachmentDownloaderImpl : public AttachmentDownloader,

void ReportResult(

const DownloadState& download_state,

const DownloadResult& result,

- const scoped_refptr<base::RefCountedString>& attachment_data,

- uint32_t attachment_crc32c);

+ const scoped_refptr<base::RefCountedString>& attachment_data);

// Extract the crc32c from an X-Goog-Hash header in |headers|.