Issue 982783002: Revert of DevTools: Remove pageAgent() call from DebuggerModel

Issue 982783002: Revert of DevTools: Remove pageAgent() call from DebuggerModel (Closed)

Created:
5 years, 9 months ago by lushnikov

Modified:
5 years, 9 months ago

Reviewers:
dgozman, sergeyv, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of DevTools: Remove pageAgent() call from DebuggerModel (patchset #2 id:20001 of https://codereview.chromium.org/975453002/) Reason for revert: This breaks F8 shortcut. @see crbug.com/464342 Original issue's description: > DevTools: Remove pageAgent() call from DebuggerModel > > BUG=462924 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191195 TBR=pfeldman@chromium.org,dgozman@chromium.org,sergeyv@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462924 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191358

Patch Set 1 #

Created: 5 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -35 lines)			Patch
M	Source/devtools/devtools.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/main/Main.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	Source/devtools/front_end/main/OverlayController.js	View	1 chunk	+0 lines, -27 lines	0 comments	Download
M	Source/devtools/front_end/main/module.json	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/sdk/DebuggerModel.js	View	3 chunks	+70 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

lushnikov

Created Revert of DevTools: Remove pageAgent() call from DebuggerModel

5 years, 9 months ago (2015-03-05 13:00:39 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982783002/1

5 years, 9 months ago (2015-03-05 13:00:59 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=191358

5 years, 9 months ago (2015-03-05 13:01:33 UTC) #3

sergeyv

5 years, 9 months ago (2015-03-06 11:24:59 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/985703003/ by sergeyv@chromium.org.

The reason for reverting is: The cause of problem was fixed in
https://codereview.chromium.org/982863002

Reapplying original patch.

Expand Messages | Collapse Messages